chore(codecs): replace native encoding fixture patch files with cfg-gated code#24971
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8eaf3cc3b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…oding-fixtures-cfg # Conflicts: # Cargo.lock
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
pront
left a comment
There was a problem hiding this comment.
Approved! Those patch files were embarrassing to say the least. Thanks for replacing them with a much cleaner feature-gated approach.
Reminder to revert the VRL dependency change.
Summary
Replaces the loose patch files (
vector_generate_fixtures.patch,vrl_generate_fixtures.patch) used to regenerate native encoding test fixtures with propergenerate-fixturesfeature flags in both this repo and the VRL repo, plus a standalone binary that writes fixtures directly to their committed location.Key changes:
generate-fixturesfeature invector-coreactivates fixture-stableArbitraryimpls (NaN-safe f64, non-empty names, no timestamps) and pulls invrl/generate-fixturesautomaticallyArbitraryimpls moved fromtest/common.rstoevent/arbitrary_impl.rs, compiled underany(test, feature = "generate-fixtures")u64::arbitrary(g)instead ofGen::new()(which calledfrom_entropy()) to ensure full determinismAgentDDSketch::set_sum_avgmethod gated on the feature instead of making fieldspubcargo run -p vector-core --features generate-fixtures --bin generate-fixtures) writes directly tolib/codecs/tests/data/native_encoding/Vector configuration
NA
How did you test this PR?
Ran the binary twice and confirmed identical checksums. Ran
cargo test -p vector-coreto confirm existing tests pass.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References