Skip to content

chore(dev): add links to design issues#25046

Merged
pront merged 2 commits intomasterfrom
fix/otlp-traces-log-namespace-todo
Mar 25, 2026
Merged

chore(dev): add links to design issues#25046
pront merged 2 commits intomasterfrom
fix/otlp-traces-log-namespace-todo

Conversation

@pront
Copy link
Copy Markdown
Member

@pront pront commented Mar 25, 2026 •
edited
Loading

Summary

log_namespace is a logs-specific concept that has been baked into the generic Deserializer trait signature. This means all non-log signal deserializers (metrics, traces) are forced to accept a parameter that is meaningless to them, and passing it through can produce unintended behavior (e.g. timestamp injection into trace events under LogNamespace::Legacy).

This PR adds TODO comments at the two key locations to document the problem and link to the tracking issues, so future contributors have the context needed to address it.

Change Type

  • Non-functional (chore, refactoring, docs)

Is this a breaking change?

  • No

Does this PR include user facing changes?

  • No. A maintainer will apply the no-changelog label to this PR.

References

@pront pront requested a review from a team as a code owner March 25, 2026 21:55
@pront pront changed the title chore: add TODO comments linking to log_namespace design issues chore(dev): add TODO comments linking to log_namespace design issues Mar 25, 2026
@pront pront changed the title chore(dev): add TODO comments linking to log_namespace design issues chore(dev): add links to design issues Mar 25, 2026
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Mar 25, 2026
@pront pront enabled auto-merge March 25, 2026 22:07
@pront @claude
chore: add TODO comments linking to log_namespace design issues
4f35c36 
#25044
#25045

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@pront pront force-pushed the fix/otlp-traces-log-namespace-todo branch from 7783b4d to 4f35c36 Compare March 25, 2026 22:07
@pront pront added this pull request to the merge queue Mar 25, 2026
Merged via the queue into master with commit 7dc3ce3 Mar 25, 2026
59 checks passed
@pront pront deleted the fix/otlp-traces-log-namespace-todo branch March 25, 2026 23:15
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thomasqueirozb thomasqueirozb thomasqueirozb approved these changes

Assignees

No one assigned

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pront @thomasqueirozb