chore(deps): bump the tonic group across 1 directory with 4 updates#25091
chore(deps): bump the tonic group across 1 directory with 4 updates#25091dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
dependabot
bot
added
domain: deps
dependabot
bot
added
domain: deps
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e11b19a68
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-build = { version = "0.13", default-features = false, features = ["transport", "prost"] } | ||
| tonic-health = { version = "0.13", default-features = false } | ||
| tonic-reflection = { version = "0.13", default-features = false, features = ["server"] } |
There was a problem hiding this comment.
tonic is pinned to 0.12 while tonic-build, tonic-health, and tonic-reflection are bumped to 0.13, which pulls in a second tonic major version with incompatible traits/types. In this repo, services from tonic_health/tonic_reflection are added to servers built with tonic::transport::Server (e.g. src/sources/vector/mod.rs and src/api/grpc_server.rs), so this version split can cause compile-time type mismatches (NamedService/service body/type incompatibility). Either keep all tonic crates on 0.12 or upgrade tonic itself to 0.13 in the same change.
Useful? React with 👍 / 👎.
dependabot
bot
changed the title
dependabot
bot
force-pushed
the
dependabot/cargo/tonic-e251c5e666
branch
2 times, most recently
from
3701968 to
ce23031
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce23031190
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-build = { version = "0.11", default-features = false, features = ["transport", "prost"] } | ||
| tonic-health = { version = "0.11", default-features = false } | ||
| tonic-reflection = { version = "0.11", default-features = false, features = ["server"] } | ||
| tonic = { version = "0.12", default-features = false, features = ["transport", "codegen", "prost", "tls", "tls-roots", "gzip"] } |
There was a problem hiding this comment.
Updating tonic to 0.12 here introduces a prost major-version split that will break gRPC codegen consumers at compile time: tonic 0.12.3 pulls prost 0.13.5 (see Cargo.lock), while workspace crates like vector-api-client and opentelemetry-proto still depend on prost 0.12.6/prost-build 0.12.6. For crates that generate stubs and then use tonic::codec::ProstCodec, request/response types derived from prost 0.12 do not satisfy the prost::Message bounds expected by tonic’s prost 0.13, so the build fails until prost, prost-build, and prost-types are upgraded in lockstep (or tonic is kept at 0.11).
Useful? React with 👍 / 👎.
dependabot
bot
force-pushed
the
dependabot/cargo/tonic-e251c5e666
branch
from
ce23031 to
d9a8a5e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9a8a5ee93
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-build = { version = "0.11", default-features = false, features = ["transport", "prost"] } | ||
| tonic-health = { version = "0.11", default-features = false } | ||
| tonic-reflection = { version = "0.11", default-features = false, features = ["server"] } | ||
| tonic = { version = "0.12", default-features = false, features = ["transport", "codegen", "prost", "tls", "tls-roots", "gzip"] } |
There was a problem hiding this comment.
Bumping tonic to 0.12 moves its transport/codegen APIs onto http v1 and hyper v1, but this workspace still uses http v0.2/hyper v0.14 in code that directly touches tonic types (for example lib/vector-api-client/src/client.rs uses http::Uri with Endpoint::from, and src/sources/util/grpc/mod.rs bounds services as Service<Request<hyper::Body>, ...>). Those are different crate types and will no longer satisfy tonic’s trait signatures, so this dependency change introduces compile-time type mismatches unless the related http/hyper usages are migrated in lockstep (or tonic stays on 0.11).
Useful? React with 👍 / 👎.
dependabot
bot
force-pushed
the
dependabot/cargo/tonic-e251c5e666
branch
2 times, most recently
from
2aad0e0 to
3833a90
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3833a906f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-health = { version = "0.11", default-features = false } | ||
| tonic-reflection = { version = "0.11", default-features = false, features = ["server"] } | ||
| tonic = { version = "0.12", default-features = false, features = ["transport", "codegen", "prost", "tls", "tls-roots", "gzip"] } | ||
| tonic-build = { version = "0.13", default-features = false, features = ["transport", "prost"] } |
There was a problem hiding this comment.
Upgrading tonic-build to 0.13 breaks existing build scripts because this workspace still calls Builder::compile/Builder::compile_with_config (e.g. lib/opentelemetry-proto/build.rs and lib/vector-api-client/build.rs), while tonic-build 0.13 exposes compile_protos/compile_protos_with_config instead. In any build that includes these crates, the build script itself will fail to compile before protobuf generation runs, so this dependency bump is not buildable without migrating those calls (or pinning tonic-build to a compatible release).
Useful? React with 👍 / 👎.
dependabot
bot
force-pushed
the
dependabot/cargo/tonic-e251c5e666
branch
from
3833a90 to
8a9af5f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a9af5f2e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-health = { version = "0.13", default-features = false } | ||
| tonic-reflection = { version = "0.13", default-features = false, features = ["server"] } |
There was a problem hiding this comment.
This bump leaves the workspace with mixed tonic majors (tonic 0.12 but tonic-health/tonic-reflection 0.13), which resolves to both tonic 0.12.3 and tonic 0.13.1 in Cargo.lock. In this repo, src/api/grpc_server.rs and src/sources/vector/mod.rs add health/reflection services to servers built from tonic::transport::Server/RoutesBuilder, and those service traits are not interchangeable across tonic major versions, so normal builds will hit type incompatibilities. Fresh evidence is that this commit updates only companion crates to 0.13 while keeping tonic at 0.12.
Useful? React with 👍 / 👎.
| tonic-health = { version = "0.11", default-features = false } | ||
| tonic-reflection = { version = "0.11", default-features = false, features = ["server"] } | ||
| tonic = { version = "0.12", default-features = false, features = ["transport", "codegen", "prost", "tls", "tls-roots", "gzip"] } | ||
| tonic-build = { version = "0.13", default-features = false, features = ["transport", "prost"] } |
There was a problem hiding this comment.
The workspace build scripts still use tonic_build::configure().compile(...) and .compile_with_config(...) (for example lib/vector-api-client/build.rs and lib/opentelemetry-proto/build.rs), but this change upgrades tonic-build to 0.13 without migrating those call sites. That causes build-script compilation failures before protobuf generation can run. Fresh evidence is that this commit pins tonic-build to 0.13 while leaving all build.rs call patterns unchanged.
Useful? React with 👍 / 👎.
dependabot
bot
force-pushed
the
dependabot/cargo/tonic-e251c5e666
branch
3 times, most recently
from
07777c1 to
8c15d46
Compare
Bumps the tonic group with 4 updates: [tonic](https://github.com/hyperium/tonic), [tonic-build](https://github.com/hyperium/tonic), [tonic-health](https://github.com/hyperium/tonic) and [tonic-reflection](https://github.com/hyperium/tonic). Updates `tonic` from 0.11.0 to 0.12.3 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.11.0...v0.12.3) Updates `tonic-build` from 0.11.0 to 0.13.1 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.11.0...v0.13.1) Updates `tonic-health` from 0.11.0 to 0.13.1 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.11.0...v0.13.1) Updates `tonic-reflection` from 0.11.0 to 0.13.1 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.11.0...v0.13.1) --- updated-dependencies: - dependency-name: tonic dependency-version: 0.12.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic - dependency-name: tonic-build dependency-version: 0.13.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic - dependency-name: tonic-health dependency-version: 0.13.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic - dependency-name: tonic-reflection dependency-version: 0.13.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/cargo/tonic-e251c5e666
branch
from
8c15d46 to
b03e928
Compare
|
Looks like these dependencies are no longer updatable, so this is no longer needed. |
Bumps the tonic group with 4 updates in the / directory: tonic, tonic-build, tonic-health and tonic-reflection.
Updates
tonicfrom 0.11.0 to 0.12.3Release notes
Sourced from tonic's releases.
... (truncated)
Changelog
Sourced from tonic's changelog.
... (truncated)
Commits
4b8d2c4chore: prepare 0.12.3 release (#1899)517b7fcUse constants for header names (#1933)3c900ebClean up EncodeBody API (#1924)e6782fefix: addtower?/utildep forchannelfeature only builds (#1954)6d93c1dchore: Make codegen independent from protoc (#1953)f074f13chore(health): Update generated code (#1951)474390bfix(tls): do not shutdown server on broken connections (#1948)ec41014chore: update releasing documentation (#1807)a09d453optimize header name handling inGrpc::map_response(#1359)99b663echore(test): Move integration test for tonic-web to tests directory (#1927)Updates
tonic-buildfrom 0.11.0 to 0.13.1Release notes
Sourced from tonic-build's releases.
... (truncated)
Changelog
Sourced from tonic-build's changelog.
... (truncated)
Commits
b303caachore: Preparev0.13.1releaseee6775cRevert "[spr] initial version (#2264)" (#2265)fd60c04[spr] initial version (#2264)aa27260feat: expose creation of HealthService and HealthReporter (#2251)9669ce4chore(tonic-bench): Fix failing bench (#2207)67e2ef9fix: tls config overwrite in endpoint (#2252)eeac1d3chore: Fix interop test certs (#2262)1c139f3chore: Addflake.nix(#2261)97001f3chore: Use inline format argument (#2260)cb6c67fchore: Use symbolic link for license file (#2241)Updates
tonic-healthfrom 0.11.0 to 0.13.1Release notes
Sourced from tonic-health's releases.
... (truncated)
Changelog
Sourced from tonic-health's changelog.
... (truncated)
Commits
b303caachore: Preparev0.13.1releaseee6775cRevert "[spr] initial version (#2264)" (#2265)fd60c04[spr] initial version (#2264)aa27260feat: expose creation of HealthService and HealthReporter (#2251)9669ce4chore(tonic-bench): Fix failing bench (#2207)67e2ef9fix: tls config overwrite in endpoint (#2252)eeac1d3chore: Fix interop test certs (#2262)1c139f3chore: Addflake.nix(#2261)97001f3chore: Use inline format argument (#2260)cb6c67fchore: Use symbolic link for license file (#2241)Updates
tonic-reflectionfrom 0.11.0 to 0.13.1Release notes
Sourced from tonic-reflection's releases.
... (truncated)
Changelog
Sourced from tonic-reflection's changelog.
... (truncated)
Commits
b303caachore: Preparev0.13.1releaseee6775cRevert "[spr] initial version (#2264)" (#2265)fd60c04[spr] initial version (#2264)aa27260feat: expose creation of HealthService and HealthReporter (#2251)9669ce4chore(tonic-bench): Fix failing bench (#2207)67e2ef9fix: tls config overwrite in endpoint (#2252)eeac1d3chore: Fix interop test certs (#2262)1c139f3chore: Addflake.nix(#2261)97001f3chore: Use inline format argument (#2260)cb6c67fchore: Use symbolic link for license file (#2241)Most Recent Ignore Conditions Applied to This Pull Request