Skip to content

chore(ci): Migrate smp regression workflow auth from static secrets to oidc #25112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pront merged 3 commits into from
Apr 6, 2026
Merged

chore(ci): Migrate smp regression workflow auth from static secrets to oidc #25112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bd0ef3
migrate smp regression workflow auth to oidc
cmetz100 Apr 2, 2026
f88b926
increase token duration
cmetz100 Apr 2, 2026
d8429ad
fmt
cmetz100 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions .github/workflows/regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,16 @@ jobs:
needs:
- should-run-gate
- resolve-inputs
# Job level permissions for downloading SMP binary
permissions:
id-token: write # Required for GitHub OIDC token exchange
steps:
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-access-key-id: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_SECRET_ACCESS_KEY }}
role-to-assume: arn:aws:iam::850406765696:role/smp-regression-oidc
aws-region: us-west-2
role-duration-seconds: 14400 # 4 hours

- name: Download SMP binary
run: |
Expand All @@ -303,6 +306,9 @@ jobs:
- resolve-inputs
- confirm-valid-credentials
- build-baseline
# Job level permissions for uploading baseline image to SMP ECR
permissions:
id-token: write # Required for GitHub OIDC token exchange
steps:
- name: "Download baseline image"
uses: actions/download-artifact@70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3 # v8.0.0
Expand All @@ -316,9 +322,9 @@ jobs:
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-access-key-id: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_SECRET_ACCESS_KEY }}
role-to-assume: arn:aws:iam::850406765696:role/smp-regression-oidc
aws-region: us-west-2
role-duration-seconds: 14400 # 4 hours

- name: Login to Amazon ECR
id: login-ecr
Expand All @@ -343,6 +349,9 @@ jobs:
- resolve-inputs
- confirm-valid-credentials
- build-comparison
# Job level permissions for uploading comparison image to SMP ECR
permissions:
id-token: write # Required for GitHub OIDC token exchange
steps:
- name: "Download comparison image"
uses: actions/download-artifact@70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3 # v8.0.0
Expand All @@ -356,9 +365,9 @@ jobs:
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-access-key-id: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_SECRET_ACCESS_KEY }}
role-to-assume: arn:aws:iam::850406765696:role/smp-regression-oidc
aws-region: us-west-2
role-duration-seconds: 14400 # 4 hours

- name: Login to Amazon ECR
id: login-ecr
Expand Down Expand Up @@ -387,6 +396,7 @@ jobs:
permissions:
contents: read # Required to checkout code
actions: write # Required to upload artifacts
id-token: write # Required for GitHub OIDC token exchange
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
Expand All @@ -395,9 +405,9 @@ jobs:
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-access-key-id: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_SECRET_ACCESS_KEY }}
role-to-assume: arn:aws:iam::850406765696:role/smp-regression-oidc
aws-region: us-west-2
role-duration-seconds: 14400 # 4 hours

- name: Login to Amazon ECR
id: login-ecr
Expand Down Expand Up @@ -462,15 +472,19 @@ jobs:
- submit-job
- should-run-gate
- resolve-inputs
# Job level permissions for downloading SMP results
permissions:
contents: read # Required to checkout code
id-token: write # Required for GitHub OIDC token exchange
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-access-key-id: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_SECRET_ACCESS_KEY }}
role-to-assume: arn:aws:iam::850406765696:role/smp-regression-oidc
aws-region: us-west-2
role-duration-seconds: 14400 # 4 hours

- name: Download SMP binary
run: |
Expand Down Expand Up @@ -503,6 +517,7 @@ jobs:
permissions:
contents: read # Required to checkout code
actions: write # Required to upload artifacts
id-token: write # Required for GitHub OIDC token exchange
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
Expand All @@ -511,9 +526,9 @@ jobs:
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-access-key-id: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_BOT_SECRET_ACCESS_KEY }}
role-to-assume: arn:aws:iam::850406765696:role/smp-regression-oidc
aws-region: us-west-2
role-duration-seconds: 14400 # 4 hours

- name: Download SMP binary
run: |
Expand Down
Loading