Skip to content

fix(ci): verify choco package install after 5xx from feed#25116

Merged
thomasqueirozb merged 2 commits intomasterfrom
fix/ci-choco-exit-code
Apr 22, 2026
Merged

fix(ci): verify choco package install after 5xx from feed#25116
thomasqueirozb merged 2 commits intomasterfrom
fix/ci-choco-exit-code

Conversation

@thomasqueirozb
Copy link
Copy Markdown
Contributor

Summary

choco install returns exit code 0 even when the chocolatey feed returns a 503, causing the Windows bootstrap to silently skip installing make and protoc. The build then fails ~30 minutes later when these tools are needed.

Adds a post-install verification via choco list --local-only so the retry logic actually triggers on transient feed errors.

Ref: https://github.com/vectordotdev/vector/actions/runs/23935387636/job/69810717854

Vector configuration

NA

How did you test this PR?

Verified the 503 behavior in the linked CI run logs where both make and protoc installs silently failed.

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Apr 3, 2026
@thomasqueirozb thomasqueirozb marked this pull request as ready for review April 3, 2026 15:07
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner April 3, 2026 15:07
@thomasqueirozb thomasqueirozb enabled auto-merge April 3, 2026 15:09
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Apr 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 3, 2026
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Apr 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Apr 22, 2026
Merged via the queue into master with commit ecdaa50 Apr 22, 2026
59 checks passed
@thomasqueirozb thomasqueirozb deleted the fix/ci-choco-exit-code branch April 22, 2026 23:55
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants