fix(startup): auto-raise file descriptor soft limit to prevent "Too many open files"#25251
Open
vparfonov wants to merge 1 commit intovectordotdev:masterfrom
Open
fix(startup): auto-raise file descriptor soft limit to prevent "Too many open files"#25251vparfonov wants to merge 1 commit intovectordotdev:masterfrom
vparfonov wants to merge 1 commit intovectordotdev:masterfrom
Conversation
…any open files" Many systems default RLIMIT_NOFILE soft limit to 1024 (Linux) or 256 (macOS), which is too low when Vector monitors large numbers of log files. This raises the soft limit to the hard limit at startup, with a macOS fallback to kern.maxfilesperproc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e90c94531d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
pront
reviewed
May 8, 2026
| } | ||
| } | ||
|
|
||
| /// Raise the soft file descriptor limit (RLIMIT_NOFILE) as high as the OS allows. |
Member
There was a problem hiding this comment.
Should we expose this option as a CLI argument instead? We can consider changing the default behavior later, it needs some more consideration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Many systems default the RLIMIT_NOFILE soft limit to 1024 (Linux) or 256 (macOS), which is too low for Vector when it monitors large numbers of log files - common in Kubernetes environments. This causes "Too many open files (os error 24)" crashes.
This PR raises the soft file descriptor limit to the hard limit at Vector startup, before any sources open files. On macOS, where the hard limit can be
RLIM_INFINITY(whichsetrlimitrejects), Vector falls back to the kernel-enforcedkern.maxfilesperproc(typically 10240).Changes:
Cargo.toml: addlibcdep and"resource"feature tonixfor rlimit accesssrc/cli.rs: callraise_file_descriptor_limit()ininit_global()before metrics init,with macOSkern.maxfilesperprocfallbackVector configuration
No configuration changes — this runs unconditionally at startup
How did you test this PR?
Unit tests: 3 tests in
cli::tests(raise limit, already-at-max, macOS sysctl)Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.