chore(deps): bump lru from 0.16.3 to 0.18.0#25301
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60f9057343
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "listenfd", | ||
| "loki-logproto", | ||
| "lru", | ||
| "lru 0.18.0", |
There was a problem hiding this comment.
Align lru lock version with manifest constraint
vector is now locked to lru 0.18.0, but the manifest still declares lru = { version = "0.16.3", ... } in Cargo.toml (which constrains to <0.17 for a 0.x crate). This makes the lockfile inconsistent with the dependency spec: cargo will either fail under --locked or rewrite Cargo.lock back to a 0.16.x resolution, so the bump is not reproducible and can break locked CI/release flows.
Useful? React with 👍 / 👎.
2d09be9 to
0272cf7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0272cf7d80
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "listenfd", | ||
| "loki-logproto", | ||
| "lru", | ||
| "lru 0.18.0", |
There was a problem hiding this comment.
Keep vector's locked lru version within manifest constraint
The lockfile now pins vector to lru 0.18.0, but Cargo.toml still declares lru = { version = "0.16.3", ... } (which only allows <0.17 for a 0.x crate). This makes dependency resolution non-reproducible: cargo ... --locked can fail or force lockfile rewrites, breaking CI/release workflows that rely on a stable lockfile.
Useful? React with 👍 / 👎.
0272cf7 to
907340c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 907340cc16
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -12875,7 +12881,7 @@ dependencies = [ | |||
| "libc", | |||
There was a problem hiding this comment.
Pin lru to a version allowed by Cargo.toml
This lockfile change pins vector to lru 0.18.0, but the workspace manifest still declares lru = { version = "0.16.3", ... } in Cargo.toml:407 (caret semantics for a 0.x crate allow <0.17.0). That makes the dependency spec and lockfile inconsistent, so reproducible/locked workflows can fail or require lockfile rewrites when Cargo resolves dependencies from the manifest.
Useful? React with 👍 / 👎.
9e0b44a to
cb8e305
Compare
812f9a0 to
89c8777
Compare
d9a544e to
fe9377c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe9377c198
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -13027,7 +13033,7 @@ dependencies = [ | |||
| "libc", | |||
There was a problem hiding this comment.
Keep vector lockfile lru within manifest range
vector is now locked to lru 0.18.0, but Cargo.toml still declares lru = "0.16.3" (caret semantics on a 0.x crate only allow <0.17.0). This makes the dependency spec and lockfile inconsistent, so cargo workflows that rely on --locked reproducibility can fail or force lockfile rewrites when resolving from the manifest.
Useful? React with 👍 / 👎.
fe9377c to
c2698e9
Compare
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.16.3 to 0.18.0. - [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md) - [Commits](jeromefroe/lru-rs@0.16.3...0.18.0) --- updated-dependencies: - dependency-name: lru dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c2698e9 to
96bda88
Compare
Bumps lru from 0.16.3 to 0.18.0.
Changelog
Sourced from lru's changelog.
Commits
dac07e3Merge pull request #234 from jeromefroe/jerome/prepare-0-18-0-release0335315Prepare 0.18.0 releasee40bbdcMerge pull request #233 from paolobarbolini/get_or_insert_mut_ref-unconstrain...a615a5bFix unconstrained lifetime inLruCache::get_or_insert_mut_ref13321a9Merge pull request #232 from jeromefroe/jerome/prepare-0-17-0-releasef7d0ecePrepare 0.17.0 release2d3d6d5Merge pull request #231 from xtqqczze/deps/hashbrown346e2feBump hashbrown to 0.17.01302b4eUpdate MSRV to 1.85.0d8c7f5cMerge pull request #230 from jeromefroe/jerome/prepare-0-16-4-release