chore(deps): bump parquet from 56.2.0 to 58.1.0#25309
Conversation
dependabot
Bot
added
domain: deps
dependabot
Bot
added
domain: deps
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d4e7ec199
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| apache-avro = { version = "0.20.0", default-features = false } | ||
| arrow = { version = "56.2.0", default-features = false, features = ["ipc", "json"], optional = true } | ||
| parquet = { version = "56.2.0", default-features = false, features = [ | ||
| parquet = { version = "58.1.0", default-features = false, features = [ |
There was a problem hiding this comment.
Bumping parquet to 58.1.0 while leaving arrow at 56.2.0 introduces incompatible Arrow types when the parquet feature is enabled: lib/codecs/src/encoding/format/parquet.rs passes arrow::record_batch::RecordBatch into parquet::arrow::ArrowWriter, and those types come from different major versions after this change. That causes codecs builds with --features parquet to fail with type mismatches, so arrow should be upgraded in lockstep with parquet (and any related top-level pins).
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
2 times, most recently
from
df60840 to
505171a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 505171a5e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| apache-avro = { version = "0.20.0", default-features = false } | ||
| arrow = { version = "56.2.0", default-features = false, features = ["ipc", "json"], optional = true } | ||
| parquet = { version = "56.2.0", default-features = false, features = [ | ||
| parquet = { version = "58.1.0", default-features = false, features = [ |
There was a problem hiding this comment.
Bumping parquet to 58.1.0 without also bumping arrow from 56.2.0 creates a cross-version type mismatch whenever the parquet encoder is compiled. Fresh evidence from the current tree: lib/codecs/src/encoding/format/parquet.rs imports arrow::record_batch::RecordBatch and passes it into parquet::arrow::ArrowWriter, so these types must come from the same Arrow major version; with arrow=56 and parquet=58, builds with the parquet feature enabled will fail.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
3 times, most recently
from
5aa6a7d to
0af4d13
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0af4d138a2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| apache-avro = { version = "0.20.0", default-features = false } | ||
| arrow = { version = "56.2.0", default-features = false, features = ["ipc", "json"], optional = true } | ||
| parquet = { version = "56.2.0", default-features = false, features = [ | ||
| parquet = { version = "58.1.0", default-features = false, features = [ |
There was a problem hiding this comment.
Bumping parquet to 58.1.0 while keeping arrow at 56.2.0 introduces incompatible Arrow types when the parquet encoder is built: lib/codecs/src/encoding/format/parquet.rs imports arrow::record_batch::RecordBatch and passes batches to parquet::arrow::ArrowWriter, which requires Arrow types from Parquet’s own major version. With --features parquet, this causes a type mismatch at compile time, so arrow needs to be upgraded in lockstep.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
2 times, most recently
from
89799ba to
5275445
Compare
💡 Codex ReviewLine 8087 in 5275445 Update the root parquet pin with the lockfile
When the top-level ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
2 times, most recently
from
d0a7b00 to
77be964
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77be9644f2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| apache-avro = { version = "0.20.0", default-features = false } | ||
| arrow = { version = "56.2.0", default-features = false, features = ["ipc", "json"], optional = true } | ||
| parquet = { version = "56.2.0", default-features = false, features = [ | ||
| parquet = { version = "58.1.0", default-features = false, features = [ |
There was a problem hiding this comment.
This bump only changes the codecs crate, but the vector package still declares parquet = "56.2.0" in the root Cargo.toml, and its codecs-parquet feature enables that direct dependency via dep:parquet as part of base. In builds of the main Vector package with parquet support, Cargo still has to resolve/build the old 56.x dependency (or add it back to the lockfile), so the dependency update is incomplete for the shipped workspace feature set rather than actually moving parquet usage to 58.x.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
6 times, most recently
from
0861ddc to
1bb776b
Compare
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
5 times, most recently
from
9793db5 to
9454a94
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9454a943a1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| apache-avro = { version = "0.20.0", default-features = false } | ||
| arrow = { version = "56.2.0", default-features = false, features = ["ipc", "json"], optional = true } | ||
| parquet = { version = "56.2.0", default-features = false, features = [ | ||
| parquet = { version = "58.1.0", default-features = false, features = [ |
There was a problem hiding this comment.
Bumping parquet to 58.1.0 here while leaving arrow at 56.2.0 in the same manifest creates an ABI/type split for parquet-enabled builds: lib/codecs/src/encoding/format/parquet.rs imports arrow::record_batch::RecordBatch and passes it to parquet::arrow::ArrowWriter, but those types come from different Arrow major versions after this change. Any build enabling codecs/parquet (including the main Vector feature chain that includes parquet codecs) will fail to compile with type mismatches.
Useful? React with 👍 / 👎.
| [[package]] | ||
| name = "parquet" | ||
| version = "56.2.0" | ||
| version = "58.1.0" |
There was a problem hiding this comment.
This lockfile update records only parquet 58.1.0, but the root package still constrains parquet to 56.2.0 and enables it via base -> codecs-parquet -> dep:parquet; with Cargo’s default requirement semantics ("56.2.0" means >=56.2.0, <57.0.0), 58.1.0 does not satisfy that path. As a result, --locked builds that include root parquet support will fail dependency resolution until the root manifest is bumped in tandem.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
2 times, most recently
from
aa7bb14 to
90b7d0a
Compare
Bumps [parquet](https://github.com/apache/arrow-rs) from 56.2.0 to 58.1.0. - [Release notes](https://github.com/apache/arrow-rs/releases) - [Changelog](https://github.com/apache/arrow-rs/blob/58.1.0/CHANGELOG.md) - [Commits](apache/arrow-rs@56.2.0...58.1.0) --- updated-dependencies: - dependency-name: parquet dependency-version: 58.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/parquet-58.1.0
branch
from
90b7d0a to
04587ad
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Bumps parquet from 56.2.0 to 58.1.0.
Release notes
Sourced from parquet's releases.
... (truncated)
Changelog
Sourced from parquet's changelog.
... (truncated)
Commits
6cadf3bPrepare for 58.1.0 Release (#9573)322f9ce[Variant] Add unshred_variant support for Binary and LargeBinary types (#9576)bc74c71feat(parquet): add content defined chunking for arrow writer (#9450)39dda22Make Sbbf Constructers Public (#9569)d53df60feat: Optimize from_bitwise_binary_op with 64-bit alignment (#9441)44f5dfcperf: Coalesce page fetches when RowSelection selects all rows (#9578)14f1eb9pyarrow: Cache the imported classes to avoid importing them each time (#9439)55a7768[Variant] Addvariant_to_arrowStructtype support (#9572)42ab0bcfix: Usedchecked_addfor bounds checks to avoid UB (#9568)88422cbarrow-flight: generate dict_ids for dicts nested inside complex types (#9556)