enhancement(metrics): Add rename tag name function for metrics#25357
Closed
ArunPiduguDD wants to merge 1 commit intomasterfrom
Closed
enhancement(metrics): Add rename tag name function for metrics#25357ArunPiduguDD wants to merge 1 commit intomasterfrom
ArunPiduguDD wants to merge 1 commit intomasterfrom
Conversation
ArunPiduguDD
added
the
no-changelog
github-actions
Bot
added
the
domain: core
ArunPiduguDD
changed the title
ArunPiduguDD
changed the title
bruceg
reviewed
May 4, 2026
|
|
||
| /// Rename a tag from `old_name` to `new_name`, overwriting `new_name` if it already exists. | ||
| /// Returns `true` if the rename was performed. | ||
| pub fn rename_with_replacement(&mut self, old_name: &str, new_name: String) -> bool { |
Member
There was a problem hiding this comment.
Could this be accomplished better by adding another remove function that doesn't call TagValueSet::into_single and then calling set_multi_value in the code that needs this method?
Contributor
Author
There was a problem hiding this comment.
Ah that's a good suggestion. Will go with that instead
Contributor
Author
There was a problem hiding this comment.
Will close this PR to have an accurate branch name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a helper function to rename existing tags in a metric with replacement (will be used in follow-up PRs)
How did you test this PR?
Added unit tests
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.