Skip to content

enhancement(tag_cardinality_limit transform): Add more fine grained controls tag cardinality#25360

Draft
ArunPiduguDD wants to merge 3 commits intomasterfrom
arun.pidugu/add-more-fine-grained-controls-tag-cardinality
Draft

enhancement(tag_cardinality_limit transform): Add more fine grained controls tag cardinality#25360
ArunPiduguDD wants to merge 3 commits intomasterfrom
arun.pidugu/add-more-fine-grained-controls-tag-cardinality

Conversation

@ArunPiduguDD
Copy link
Copy Markdown
Contributor

Summary

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@github-actions github-actions Bot added docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: transforms Anything related to Vector's transform components domain: external docs Anything related to Vector's external, public documentation domain: core Anything related to core crates i.e. vector-core, core-common, etc labels May 4, 2026
@kaarolch
Copy link
Copy Markdown
Contributor

kaarolch commented May 4, 2026

btw. Do you have any use case why include metrics exclusion to cardinality_tags would be better compare to current possible solution: route + remap which should be more sufficient instead scan cardinality list?

#name: metrics_route_cardinality_limi
type: route
inputs:
  - vector_ingress
route:
  cardinality_bypass: .tags.cardinality_bypass == "true"
...  
type: tag_cardinality_limit
inputs:
  - metrics_route_cardinality_limit._unmatched
.....

If you connect it with enrichment table you can manage metrics from external csv.

:FYI another PR for tags exclusion: #25316.

@ArunPiduguDD ArunPiduguDD changed the title enhancement(Tags Cardinality): Add more fine grained controls tag cardinality enhancement(tag_cardinality_limit transform): Add more fine grained controls tag cardinality May 4, 2026
@ArunPiduguDD ArunPiduguDD force-pushed the arun.pidugu/add-more-fine-grained-controls-tag-cardinality branch from df32f77 to f64d3bb Compare May 4, 2026 20:32
@github-actions github-actions Bot removed the domain: core Anything related to core crates i.e. vector-core, core-common, etc label May 4, 2026
@ArunPiduguDD
Copy link
Copy Markdown
Contributor Author

@kaarolch This would be if you wanted to different limits for tags in a metric (or if only one tag on a metric should be excluded from the limit)

@ArunPiduguDD
Copy link
Copy Markdown
Contributor Author

Took a look at your PR, if we add support for per tag limits I wonder if exclude_tags might be integrated with this approach

@ArunPiduguDD ArunPiduguDD force-pushed the arun.pidugu/add-more-fine-grained-controls-tag-cardinality branch 2 times, most recently from cd5958e to 61f210f Compare May 5, 2026 00:20
…ity' of github.com:vectordotdev/vector into arun.pidugu/add-more-fine-grained-controls-tag-cardinality
@ArunPiduguDD ArunPiduguDD force-pushed the arun.pidugu/add-more-fine-grained-controls-tag-cardinality branch from 61f210f to 63f5251 Compare May 5, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation domain: transforms Anything related to Vector's transform components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants