fix(ci): skip dd-sts federation on fork PRs via ACTIONS_ID_TOKEN_REQUEST_URL guard#25399
fix(ci): skip dd-sts federation on fork PRs via ACTIONS_ID_TOKEN_REQUEST_URL guard#25399thomasqueirozb merged 3 commits intomasterfrom
Conversation
thomasqueirozb
added
the
no-changelog
github-actions
Bot
added
the
domain: ci
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7276601bc5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0959f05b7a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
Summary
Fork PRs from external contributors cause the
test / Testsjob to fail at thedd-tokenaction. GitHub setsid-token: nonefor fork PRs regardless of what the workflow declares, soACTIONS_ID_TOKEN_REQUEST_URLis unset anddd-sts-actionerrors. The previouscontinue-on-error: trueon the inner composite action step does not prevent the composite action itself from being marked as failed, causing all subsequent steps (setup,Run tests) to be skipped.Fix: guard the federation step with
if: ${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }}so it is skipped entirely on fork PRs instead of failing.Vector configuration
NA
How did you test this PR?
Verified against the failing run:
Tested over at https://github.com/vectordotdev/ci-sandbox/pull/28
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References