Skip to content

chore(dev): make -D warnings the default via .cargo/config.toml#25400

Merged
pront merged 2 commits intomasterfrom
chore/deny-warnings-default
May 8, 2026
Merged

chore(dev): make -D warnings the default via .cargo/config.toml#25400
pront merged 2 commits intomasterfrom
chore/deny-warnings-default

Conversation

@thomasqueirozb
Copy link
Copy Markdown
Contributor

Summary

Move -D warnings from the CI setup action and vdev's explicit clippy args into the [target.'cfg(all())'] section of .cargo/config.toml. This makes warnings-as-errors the default for all targets and all cargo subcommands (build, test, clippy) in both local development and CI.

Previously, -D warnings was injected only for Linux targets in CI via a ~/.cargo/config.toml override, and passed explicitly to clippy via vdev. Now it's in one place and covers all platforms.

Vector configuration

NA

How did you test this PR?

NA

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

NA

@github-actions github-actions Bot added domain: ci Anything related to Vector's CI environment domain: vdev Anything related to the vdev tooling labels May 8, 2026
@thomasqueirozb thomasqueirozb changed the title chore: make -D warnings the default via .cargo/config.toml chore(dev): make -D warnings the default via .cargo/config.toml May 8, 2026
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 8, 2026
@thomasqueirozb thomasqueirozb marked this pull request as ready for review May 8, 2026 18:55
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner May 8, 2026 18:55
@pront pront enabled auto-merge May 8, 2026 18:55
@pront pront added this pull request to the merge queue May 8, 2026
Merged via the queue into master with commit f334660 May 8, 2026
60 checks passed
@pront pront deleted the chore/deny-warnings-default branch May 8, 2026 20:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: ci Anything related to Vector's CI environment domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants