chore(ci): centralize CARGO_INCREMENTAL=0 in setup action#25401
Merged
thomasqueirozb merged 3 commits intomasterfrom May 9, 2026
Merged
chore(ci): centralize CARGO_INCREMENTAL=0 in setup action#25401thomasqueirozb merged 3 commits intomasterfrom
thomasqueirozb merged 3 commits intomasterfrom
Conversation
github-actions
Bot
added
the
domain: ci
thomasqueirozb
added
the
no-changelog
pront
approved these changes
May 8, 2026
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0293b1a0cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incremental compilation is only useful when intermediate artifacts are cached between builds. In CI, each run starts from a clean state, so incremental compilation adds overhead (extra bookkeeping, larger artifacts) without any benefit. It can also cause subtle cache poisoning issues where stale incremental state from a partially-warmed cache leads to build failures.
Previously,
CARGO_INCREMENTAL=0was set independently in several workflow files, and some workflows didn't set it at all. This consolidates it into the shared setup action so it's applied uniformly across all CI jobs without requiring each workflow to remember to set it.Vector configuration
NA
How did you test this PR?
NA
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
NA