Skip to content

chore(ci): centralize CARGO_INCREMENTAL=0 in setup action #25401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasqueirozb merged 3 commits into from
May 9, 2026
Merged

chore(ci): centralize CARGO_INCREMENTAL=0 in setup action #25401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0293b1a
chore(ci): centralize CARGO_INCREMENTAL=0 in setup action
thomasqueirozb May 8, 2026
ec819fb
Merge branch 'master' into ci/cargo-incremental-0
thomasqueirozb May 8, 2026
1ae4faf
Update .github/actions/setup/action.yml
thomasqueirozb May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ runs:
echo "RUST_BACKTRACE=full" >> "$GITHUB_ENV"
# Set nice CI colors
echo "CARGO_TERM_COLOR=always" >> "$GITHUB_ENV"
# Incremental compilation is useless in CI: no state is shared between runs
Comment thread
thomasqueirozb marked this conversation as resolved.
Outdated
echo "CARGO_INCREMENTAL=0" >> "$GITHUB_ENV"
fi

- name: Enable rust matcher
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ permissions:
contents: read

env:
CARGO_INCREMENTAL: "0" # Disable incremental compilation for coverage
CI: true

jobs:
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/k8s_e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ jobs:
if: ${{ !failure() && !cancelled() && github.event_name != 'pull_request' && needs.changes.outputs.website_only != 'true' && needs.changes.outputs.k8s != 'false' }}
# cargo-deb requires a release build, but we don't need optimizations for tests
env:
CARGO_PROFILE_RELEASE_OPT_LEVEL: 0
CARGO_PROFILE_RELEASE_LTO: thin # fat LTO OOMs/timeouts on standard 16GB runners; thin is sufficient to verify linking
CARGO_PROFILE_RELEASE_CODEGEN_UNITS: 256
CARGO_INCREMENTAL: 0
DISABLE_MOLD: true
Comment thread
thomasqueirozb marked this conversation as resolved.
steps:
- name: Checkout branch
Expand Down Expand Up @@ -211,7 +207,6 @@ jobs:
env:
USE_MINIKUBE_CACHE: "true"
SKIP_PACKAGE_DEB: "true"
CARGO_INCREMENTAL: 0
HELM_CHART_REPO: ${{ github.workspace }}/helm-charts/charts/vector
with:
timeout_minutes: 45
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test-make-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ jobs:
id-token: write
timeout-minutes: 90
env:
CARGO_INCREMENTAL: 0
DD_ENV: "ci"
steps:
- name: Checkout branch
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ permissions:
contents: read

env:
CARGO_INCREMENTAL: "0"
CI: true
DD_ENV: "ci"

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/unit_mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ jobs:
unit-mac:
runs-on: macos-14-xlarge
timeout-minutes: 90
env:
CARGO_INCREMENTAL: 0
steps:
- name: Checkout branch
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
Loading