feat(aws_cloudwatch_logs sink): allow setting the log class#25448
Open
vivshaw wants to merge 1 commit into
Open
feat(aws_cloudwatch_logs sink): allow setting the log class#25448vivshaw wants to merge 1 commit into
vivshaw wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
vivshaw
commented
May 16, 2026
| /// [log_class]: https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CloudWatch_Logs_Log_Classes.html | ||
| #[configurable_component] | ||
| #[derive(Clone, Copy, Debug, Default, PartialEq, Eq)] | ||
| #[serde(rename_all = "SCREAMING_SNAKE_CASE")] |
Author
There was a problem hiding this comment.
did this to match how y'all are handling S3 storage classes, which you have as SCREAMING_SNAKE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as captured in #22008, it's not currently possible to set the log group used by
create_missing_group. this means it always defaults to Standard, and one cannot select Infrequent Access. a prior attempt was made in #22031, but later abandoned. this PR revives that attempt. effectively the same approach is used, only minor tweaks here.change is backwards-compatible, all existing uses should default to
STANDARDjust like they already do.Vector configuration
config should look a little somethin' like this:
How did you test this PR?
lemme know if i missed anything!
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
create_missing_group#22008