fix(shutdown): Update known lifecycle flow to warn not error#25458
Open
taylorchandleryoung wants to merge 2 commits into
Open
fix(shutdown): Update known lifecycle flow to warn not error#25458taylorchandleryoung wants to merge 2 commits into
taylorchandleryoung wants to merge 2 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
| message = "Connection closed by peer before acknowledgement could be sent.", | ||
| error = %self.error, | ||
| ); | ||
| counter!(CounterName::ConnectionShutdownTotal, "mode" => "tcp").increment(1); |
Contributor
There was a problem hiding this comment.
Another idea that came to mind, might this also be potentially misleading? There are other places the connection can be shutdown, I see StreamClosedError and DecoderFramingError, we would then have to increment this counter on those cases too otherwise the metric isn't 100% acccurate.
I think this counter can maybe be placed somewhere else where we would be exiting the connection - gracefully or ungracefully, since it doesn't really depend on those conditions to be incremented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We received feedback and confusion around
Error writing acknowledgement, dropping connection.This is a lifecycle event, not an error, so we can likely downgrade to warn in this case.Updating the flow to match the treatment of TcpSocketConnectionShutdown (warn + connection shutdown counter, no component_errors_total increment).
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.