fix(aggregate transform): Fix incorrectly dropped events bug in metrics aggregate transform

[ArunPiduguDD]

Summary

There appears to be a major bug in the aggregate transform. According to the official docs for certain mode types incremental or absolute metric kinds should be ignored (e.g. in Sum mode absolute metrics should be ignored). However it seems the current behavior is to silently drop the events (in the example absolute metrics would be dropped if the mode is Sum).

Makes a fix to stop dropping non matching events and pass them through.

Vector configuration

sources:
    otel_in:
      type: opentelemetry
      grpc:
        address: "0.0.0.0:4317"

  transforms:
    agg:
      type: aggregate
      inputs: [otel_in.metrics]
      interval_ms: 5000
      mode: sum

  sinks:
    console_out:
      type: console
      inputs: [agg]
      encoding:
        codec: json

How did you test this PR?

Tested with above config

Change Type

• Bug fix
• New feature
• Dependencies
• Non-functional (chore, refactoring, docs)
• Performance

Is this a breaking change?

• Yes
• No

Does this PR include user facing changes?

• Yes. Please add a changelog fragment based on our guidelines.
• No. A maintainer will apply the no-changelog label to this PR.

References

Notes

• Please read our Vector contributor resources.
• Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
• Some CI checks run only after we manually approve them.
  • We recommend adding a pre-push hook, please see this template.
  • Alternatively, we recommend running the following locally before pushing to the remote branch:
    • make fmt
    • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
    • make test
• After a review is requested, please avoid force pushes to help us review incrementally.
  • Feel free to push as many commits as you want. They will be squashed into one before merging.
  • For example, you can run git merge origin master and git push.
• If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
  run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

[bruceg]

Good catch!

[pront]

Let's also improve the docs, for example "Sums incremental metrics, ignores absolute." -> "Sums incremental metrics, absolute metrics pass through unchanged."

[ArunPiduguDD]

Let's also improve the docs, for example "Sums incremental metrics, ignores absolute." -> "Sums incremental metrics, absolute metrics pass through unchanged."

@pront Just realized I undid this, updating

[ArunPiduguDD]

Let's also improve the docs, for example "Sums incremental metrics, ignores absolute." -> "Sums incremental metrics, absolute metrics pass through unchanged."

@pront Just realized I undid this, updating

Updated now

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 496fd61c0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".