fix(metrics): restore IndexMap for unbounded MetricSet to fix CPU regression#25493
Merged
Conversation
ddc6088 to
4de1fa7
Compare
e545bce to
ce224f0
Compare
pront
approved these changes
May 28, 2026
…nforce_capacity_policy Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricSetwas changed fromIndexMaptoLruCachein #23374 to support theincremental_to_absolutetransform's capacity eviction feature. However,LruCache::get_mutunconditionally updates LRU bookkeeping (pointer manipulation in a doubly-linked list) on every metric lookup, even when no capacity policy is configured. For high-throughput metrics pipelines (e.g.prometheus_remote_writesinks processing thousands of metrics/second) this per-metric overhead accumulates significantly on the hot path and is the root cause of the CPU regression reported in #24058 that persists in v0.55.0 after the buffer hot-path fix (#24995) and file source fix (#25064).MetricSetnow uses an eitherIndexMaporLruCacheif needed, meaning that performance should decrease unless the user is using theincremental_to_absolutetransform.Vector configuration
NA
How did you test this PR?
NA
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References