feat(azure_blob sink): support blob index tags and metadata#25545
feat(azure_blob sink): support blob index tags and metadata#25545Danielku15 wants to merge 4 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Any of the maintainers around who can give feedback this feature contribution? I'd like to also implement the AppendBlob support soon-ish and this makes most sense with this feature also in place. The two features would be quite crucial for us to use vector.dev in product, without them we need to look for some alternative solutions. No intention to be pushy, just trying to understand the general release cycle and policies on external contributions 😉 |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb7b08e504
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
rtrieu
left a comment
There was a problem hiding this comment.
hi @Danielku15 left you some editorial suggestions for your consideration.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
|
@rtrieu Thanks for the feedback. I've applied all changes. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89d143a6f8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Hi @Danielku15, I'm not a maintainer, but have done a bunch of Azure sink stuff recently. This looks good! Two comments:
|
Summary
Adds blob tags and metadata support to the
azure_blobsink. This updates request building and Azure common config handling so tags/metadata are forwarded correctly, and adds unit + Azurite-backed integration coverage for the new behavior.Vector configuration
Example config used during testing:
How did you test this PR?
Ran:
cargo fmt --all --checkcargo clippy --no-default-features --features sinks-azure_blob --tests -- -D warningscargo test --no-default-features --features sinks-azure_blob azure_blob_build_request_with_blob_ -- --nocapturecargo test --no-default-features --features sinks-azure_blob,azure-blob-integration-tests sinks::azure_blob::integration_tests:: -- --nocapturecargo vdev check generated-docscargo vdev check markdown./scripts/check_changelog_fragments.shChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Closes: #22316
Notes
No notes from my side.