Skip to content

docs(buffers): note known restart bugs in disk buffer docs#25679

Merged
pront merged 2 commits into
masterfrom
docs/disk-buffer-restart-warning
Jun 25, 2026
Merged

docs(buffers): note known restart bugs in disk buffer docs#25679
pront merged 2 commits into
masterfrom
docs/disk-buffer-restart-warning

Conversation

@pront

@pront pront commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary

Adds a brief callout to the buffering model docs noting the known disk buffer restart bugs, with a link to the open issue list.

Vector configuration

N/A

How did you test this PR?

Docs-only change.

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@github-actions github-actions Bot added the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Jun 24, 2026
@datadog-vectordotdev

This comment has been minimized.

@jonasrichard

Copy link
Copy Markdown

@pront If we want to give it a try and fix the issue, do you have any idea where and why the issue can come up.

About where I would go into lib/vector-buffers and see how they persistent 'pointers' are handled. But I have no idea the design of that, if it is support to implement some crash-safe solution.

Also do you know any minefield which I should be aware of?

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 25, 2026
@pront pront force-pushed the docs/disk-buffer-restart-warning branch from c2b7961 to 9a13f5a Compare June 25, 2026 13:15
@pront pront marked this pull request as ready for review June 25, 2026 13:15
@pront pront requested review from a team as code owners June 25, 2026 13:15
@github-actions github-actions Bot removed the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Jun 25, 2026
@pront

pront commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@pront If we want to give it a try and fix the issue, do you have any idea where and why the issue can come up.

About where I would go into lib/vector-buffers and see how they persistent 'pointers' are handled. But I have no idea the design of that, if it is support to implement some crash-safe solution.

Also do you know any minefield which I should be aware of?

Hi, @jonasrichard it depends on your pipeline, for example we observed bugs across Vector restarts. Generally, please take a look at the open issues and comment on those.

@pront pront added this pull request to the merge queue Jun 25, 2026
@pront pront removed this pull request from the merge queue due to a manual request Jun 25, 2026

@janine-c janine-c left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small and optional style suggestion 🙂

Comment thread website/content/en/docs/architecture/buffering-model.md Outdated
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
@pront pront enabled auto-merge June 25, 2026 18:50
@pront pront added this pull request to the merge queue Jun 25, 2026
Merged via the queue into master with commit 2f4ba86 Jun 25, 2026
62 checks passed
@pront pront deleted the docs/disk-buffer-restart-warning branch June 25, 2026 19:03
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants