fix(ci): fix two failures in cleanup-ghcr-images workflow#25684
Conversation
github-actions
Bot
added
the
domain: ci
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7f04abe79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pront
added
the
no-changelog
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dd8f581ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67d3d07b9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fix two bugs in the cleanup-ghcr-images workflow that caused every weekly run to fail: - cleanup-test-runner: fix package name from 'test-runner' to 'vector/test-runner' (the package is namespaced under vector in GHCR) - cleanup-test-runner: remove num-old-versions-to-delete which is mutually exclusive with min-versions-to-keep in actions/delete-package-versions v5, causing "Invalid input combination" - cleanup-vector-nightlies: remove this job entirely; GITHUB_TOKEN with packages:write cannot delete org-owned container package versions (delete:packages scope required). Will be re-added using the GitHub App token.
pront
force-pushed
the
fix/cleanup-ghcr-images-workflow
branch
from
ea0846e to
dd5a9b3
Compare
2 participants
Summary
The
cleanup-ghcr-imagesworkflow has been failing on every weekly run due to two bugs in thecleanup-test-runnerjob:vector/test-runnerin GHCR, nottest-runner. The action was failing immediately withget versions API failed. Package not found.num-old-versions-to-deleteandmin-versions-to-keepare mutually exclusive inactions/delete-package-versionsv5. Specifying both causedInvalid input combinationon every run.The
cleanup-vector-nightliesjob is removed. Investigation revealed thatGITHUB_TOKENwithpackages: writecannot delete org-owned container package versions — thedelete:packagesscope is required, whichGITHUB_TOKENdoes not provide.Until then, we can run purge github nightly after each release.
How did you test this PR?
workflow_dispatchruns on the branch;cleanup-test-runnernow passes cleanly.vector/test-runnerpackage exists at the correct GHCR path.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.