-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(vdev): add --features flag and FEATURES env var support to build/check/test commands #25688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pront
wants to merge
11
commits into
master
Choose a base branch
from
pront/vdev-features-flag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
17e7679
chore(vdev): replace positional features with --features flag in chec…
pront a86f094
chore(vdev): rename --feature to --features and wire FEATURES env var…
pront dd83978
chore(vdev): add --features and --no-default-features flags to test c…
pront 6749496
chore(vdev): fix rustfmt formatting in test command
pront 6d0febc
chore(vdev): bump version to 0.3.5
pront 05a7c14
chore(vdev): pass --features to check-clippy only when FEATURES is no…
pront 3375f1a
chore(vdev): restore passthrough guard to avoid double --features in …
pront 904ed13
chore(vdev): remove FEATURES env binding from check rust to preserve …
pront 75b53d8
Merge remote-tracking branch 'origin/master' into pront/vdev-features…
pront 94bf42c
chore(vdev): filter empty strings from parsed FEATURES to avoid --fea…
pront 07c329c
chore(vdev): quote FEATURES expansion in Makefile to prevent shell wo…
pront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For direct
cargo vdev check rustinvocations, settingFEATURES=...is still ignored because this new--featuresfield is the only one in the changed commands withoutenv = "FEATURES"(checkedcheck rust --help: it prints-F, --features <FEATURES>with no env marker, while build/test/crate-versions show[env: FEATURES=]). In that scenarioFEATURES=component-validation-tests cargo vdev check rustfalls through to the--all-featurespath instead of linting the requested feature set, so the advertised env-var support for check/clippy only works when callers happen to go through the Makefile.Useful? React with 👍 / 👎.