Skip to content

chore(azure sinks): refactor Blob code out of azure_common#25689

Merged
pront merged 4 commits into
vectordotdev:masterfrom
jlaundry:chore-cleanup-azure_common
Jun 27, 2026
Merged

chore(azure sinks): refactor Blob code out of azure_common#25689
pront merged 4 commits into
vectordotdev:masterfrom
jlaundry:chore-cleanup-azure_common

Conversation

@jlaundry

Copy link
Copy Markdown
Contributor

Summary

As Blob Storage was the initial Azure sink, many of the Blob-specific components were created in the azure_common module.

This refactor simply moves the Blob code out, leaving azure_common with authentication (shared with azure_logs_ingestion), SAS token parsing, and connection string parsing (while currently only used by azure_blob, SAS tokens and connection strings are also available in Event Hubs, Queues, and Tables).

Vector configuration

N/A - no change to config.

How did you test this PR?

cargo vdev int test azure and soak test in my lab.

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

jlaundry and others added 4 commits June 26, 2026 20:30
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
@jlaundry jlaundry requested a review from a team as a code owner June 26, 2026 20:51
@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Jun 26, 2026
@datadog-vectordotdev

This comment has been minimized.

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 26, 2026
@pront pront enabled auto-merge June 26, 2026 23:28
@pront pront added this pull request to the merge queue Jun 26, 2026
Merged via the queue into vectordotdev:master with commit 0f80faf Jun 27, 2026
82 of 83 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants