Skip to content

chore(tests): checks function return type#1818

Open
JakubOnderka wants to merge 1 commit into
vectordotdev:mainfrom
JakubOnderka:test-return-type
Open

chore(tests): checks function return type#1818
JakubOnderka wants to merge 1 commit into
vectordotdev:mainfrom
JakubOnderka:test-return-type

Conversation

@JakubOnderka

Copy link
Copy Markdown
Contributor

Summary

Resolves #1638

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

cargo test

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

@JakubOnderka
JakubOnderka requested a review from a team as a code owner June 15, 2026 10:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1b2d81b37

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/value/value.rs
}
}

#[cfg(test)]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match as_kind_id's cfg to the test utilities

This helper is gated only by cfg(test), but it both imports crate::compiler and is now called from compiler::test_util, which is compiled under cfg(any(test, feature = "test")). That breaks feature-specific builds: cargo test --no-default-features --features value compiles this method without the compiler module, while crates enabling features = ["compiler", "test"] can expand test_function! without Value::as_kind_id being present. Gate the helper on the same compiler/test-util configuration or move the mapping into test_util.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function::return_kind should be checked

1 participant