chore(tests): checks function return type#1818
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1b2d81b37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
Match as_kind_id's cfg to the test utilities
This helper is gated only by cfg(test), but it both imports crate::compiler and is now called from compiler::test_util, which is compiled under cfg(any(test, feature = "test")). That breaks feature-specific builds: cargo test --no-default-features --features value compiles this method without the compiler module, while crates enabling features = ["compiler", "test"] can expand test_function! without Value::as_kind_id being present. Gate the helper on the same compiler/test-util configuration or move the mapping into test_util.
Useful? React with 👍 / 👎.
e1b2d81 to
49a354b
Compare
Summary
Resolves #1638
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.