demos: improve code quality (#302)

Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>

Author: VDanielEdwards

Demos/communication/Flexray/FlexrayDemoCommon.hpp

@@ -2,6 +2,7 @@
 //
 // SPDX-License-Identifier: MIT
 
+#pragma once
 
 #include "silkit/services/flexray/all.hpp"
 #include "silkit/services/flexray/string_utils.hpp"
@@ -91,7 +92,7 @@ class FlexrayNode
 
 private:
     IFlexrayController* _flexrayController{nullptr};
-    FlexrayControllerConfig _controllerConfig;
+    FlexrayControllerConfig _controllerConfig{};
     FlexrayPocStatusEvent _lastPocStatus{};
     int _msgId = 0;
     bool _configured{false};
@@ -217,9 +218,9 @@ class FlexrayNode
     }
 };
 
-auto MakeControllerConfig() -> FlexrayControllerConfig
+inline auto MakeControllerConfig() -> FlexrayControllerConfig
 {
-    FlexrayClusterParameters clusterParams;
+    FlexrayClusterParameters clusterParams{};
     clusterParams.gColdstartAttempts = 8;
     clusterParams.gCycleCountMax = 63;
     clusterParams.gdActionPointOffset = 2;
@@ -241,7 +242,7 @@ auto MakeControllerConfig() -> FlexrayControllerConfig
     clusterParams.gPayloadLengthStatic = 13;
     clusterParams.gSyncFrameIDCountMax = 15;
 
-    FlexrayNodeParameters nodeParams;
+    FlexrayNodeParameters nodeParams{};
     nodeParams.pAllowHaltDueToClock = 1;
     nodeParams.pAllowPassiveToActive = 0;
     nodeParams.pChannels = FlexrayChannel::AB;
@@ -265,7 +266,7 @@ auto MakeControllerConfig() -> FlexrayControllerConfig
     nodeParams.pdMicrotick = FlexrayClockPeriod::T25NS;
     nodeParams.pSamplesPerMicrotick = 2;
 
-    FlexrayControllerConfig config;
+    FlexrayControllerConfig config{};
     config.clusterParams = clusterParams;
     config.nodeParams = nodeParams;
 

Demos/communication/Flexray/FlexrayNode0Demo.cpp

@@ -37,7 +37,7 @@ class FlexrayNode0 : public ApplicationBase
 
         // The specific buffer configs for this node
         std::vector<FlexrayTxBufferConfig> bufferConfigs;
-        FlexrayTxBufferConfig baseBufferCfg;
+        FlexrayTxBufferConfig baseBufferCfg{};
         baseBufferCfg.offset = 0;
         baseBufferCfg.repetition = 1;
         baseBufferCfg.hasPayloadPreambleIndicator = false;
@@ -88,8 +88,9 @@ class FlexrayNode0 : public ApplicationBase
 
 int main(int argc, char** argv)
 {
-    Arguments args;
+    Arguments args{};
     args.participantName = "Node0";
+
     FlexrayNode0 app{args};
     app.SetupCommandLineArgs(argc, argv, "SIL Kit Demo - Flexray: Node0 of a two-node Flexray system",
                              {ApplicationBase::DefaultArg::Async});

Demos/communication/Flexray/FlexrayNode1Demo.cpp

@@ -7,7 +7,7 @@
 
 using namespace SilKit::Services::Flexray;
 
-class FlexrayNode0 : public ApplicationBase
+class FlexrayNode1 : public ApplicationBase
 {
 public:
     // Inherit constructors
@@ -37,7 +37,7 @@ class FlexrayNode0 : public ApplicationBase
 
         // The specific buffer configs for this node
         std::vector<FlexrayTxBufferConfig> bufferConfigs;
-        FlexrayTxBufferConfig baseBufferCfg;
+        FlexrayTxBufferConfig baseBufferCfg{};
         baseBufferCfg.offset = 0;
         baseBufferCfg.repetition = 1;
         baseBufferCfg.hasPayloadPreambleIndicator = false;
@@ -88,9 +88,10 @@ class FlexrayNode0 : public ApplicationBase
 
 int main(int argc, char** argv)
 {
-    Arguments args;
+    Arguments args{};
     args.participantName = "Node1";
-    FlexrayNode0 app{args};
+
+    FlexrayNode1 app{args};
     app.SetupCommandLineArgs(argc, argv, "SIL Kit Demo - Flexray: Node1 of a two-node Flexray system",
                              {ApplicationBase::DefaultArg::Async});
 

Demos/communication/include/ApplicationBase.hpp

@@ -55,6 +55,8 @@ class ApplicationBase
         _commandLineParser = std::make_shared<CommandlineParser>();
     }
 
+    virtual ~ApplicationBase() = default;
+
 protected:
     // Must be implemented by the actual application
 

docs/changelog/versions/latest.md

@@ -1,3 +1,5 @@
 # [5.0.4] - UNRELEASED
 
-> This changelog entry is still empty.
+## Fixed
+
+- `demos`: improved code quality