Skip to content

quality: improve warning flags and fix issues#321

Open
VDanielEdwards wants to merge 5 commits intomainfrom
dev/quality/streamline-warning-flags
Open

quality: improve warning flags and fix issues#321
VDanielEdwards wants to merge 5 commits intomainfrom
dev/quality/streamline-warning-flags

Conversation

@VDanielEdwards
Copy link
Copy Markdown
Member

@VDanielEdwards VDanielEdwards commented May 7, 2026

Subject

Enables more warning flags for GCC and fixes resulting issues.

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VDanielEdwards VDanielEdwards self-assigned this May 7, 2026
@VDanielEdwards VDanielEdwards force-pushed the dev/quality/streamline-warning-flags branch 5 times, most recently from e1d392d to 849161f Compare May 7, 2026 10:27
@VDanielEdwards VDanielEdwards changed the title quality: improve warning flags for gcc and fix issues quality: improve warning flags and fix issues May 7, 2026
@VDanielEdwards VDanielEdwards marked this pull request as ready for review May 7, 2026 11:04
@VDanielEdwards VDanielEdwards requested a review from MariusBgm May 7, 2026 11:05
@VDanielEdwards VDanielEdwards force-pushed the dev/quality/streamline-warning-flags branch from 849161f to f934ab0 Compare May 7, 2026 14:29
…headers, ifdefs, dummy source

Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
@VDanielEdwards VDanielEdwards force-pushed the dev/quality/streamline-warning-flags branch from f934ab0 to 56f0468 Compare May 7, 2026 14:31
Copy link
Copy Markdown
Collaborator

@MariusBgm MariusBgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread SilKit/cmake/SilKitBuildSettings.cmake Outdated
Comment thread SilKit/source/SilKitForceIncludes.cpp
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
…ns for headers, ifdefs, dummy source

Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
@VDanielEdwards VDanielEdwards added needs reviewer This issue is looking for a reviewer. and removed needs reviewer This issue is looking for a reviewer. labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants