Skip to content

cookbook(llamaindex): pass memory= to agent.run(), not ReActAgent constructor #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DK09876 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cookbook(llamaindex): pass memory= to agent.run(), not ReActAgent constructor #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions notebooks/08-llamaindex-react-agent.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"from llama_index.core.agent import ReActAgent\n",
"\n",
"\n",
"def create_memory_agent(user_id: str) -> ReActAgent:\n",
"def create_memory_agent(user_id: str) -> tuple[ReActAgent, HindsightMemory]:\n",
" \"\"\"Create a ReAct agent with automatic per-user memory.\"\"\"\n",
" memory = HindsightMemory.from_client(\n",
" client=client,\n",
Expand All @@ -133,13 +133,14 @@
" context=\"llamaindex-cookbook\",\n",
" )\n",
"\n",
" return ReActAgent(\n",
" agent = ReActAgent(\n",
" tools=[], # No memory tools needed — memory is automatic\n",
" llm=OpenAI(model=\"gpt-4o-mini\"),\n",
" memory=memory,\n",
" system_prompt=\"You are a helpful assistant. Answer questions using your memory of past conversations.\",\n",
" verbose=True,\n",
" )"
" )\n",
"\n",
" return agent, memory"
]
},
{
Expand Down Expand Up @@ -172,10 +173,11 @@
"metadata": {},
"outputs": [],
"source": [
"agent = create_memory_agent(\"alice\")\n",
"agent, memory = create_memory_agent(\"alice\")\n",
"response = await agent.run(\n",
" \"Hi! I'm Alice. I'm a data scientist who works with Python and SQL. \"\n",
" \"I prefer dark mode and use VS Code.\",\n",
" memory=memory,\n",
" max_iterations=10,\n",
")\n",
"print(f\"\\nAgent: {response}\")"
Expand Down Expand Up @@ -210,8 +212,8 @@
"metadata": {},
"outputs": [],
"source": [
"agent = create_memory_agent(\"alice\")\n",
"response = await agent.run(\"What IDE do I use? And what's my job?\", max_iterations=10)\n",
"agent, memory = create_memory_agent(\"alice\")\n",
"response = await agent.run(\"What IDE do I use? And what's my job?\", memory=memory, max_iterations=10)\n",
"print(f\"\\nAgent: {response}\")"
]
},
Expand Down
Loading