Harden fenced JSON parsing#2557
Closed
koriyoshi2041 wants to merge 1 commit into
Closed
Conversation
Member
|
Superseded by #2610, which combines the line-based fence stripping from #2563 (already merged) with the parse-validated outer-JSON-span fallback from this PR. Thanks @koriyoshi2041 — the parse-validation idea here is the more robust part and it's carried forward in #2610 (with your partial-fence / non-JSON-fence cases covered in tests). |
benfrank241
added a commit
that referenced
this pull request
Jul 7, 2026
…ON (#2610) Grafts the parse-validated fallback from #2557 onto the line-based fence stripper merged in #2563: after stripping, if the candidate is not valid JSON (partial/absent fence, prose-wrapped or truncated output), fall back to the outermost parseable {..}/[..] span. Never returns a worse candidate than the raw content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2542.
Tests
Risk
Low. This only changes the fenced-response cleanup helper and adds focused coverage for parse validation, non-JSON fences, partial fences, and backticks inside JSON strings.