Fix _strip_code_fences truncating JSON when content contains inner backticks#2563
Merged
benfrank241 merged 2 commits intoJul 7, 2026
Merged
Conversation
…ckticks
The old implementation used content.split('')[0] to strip
markdown code fences from LLM responses. This finds the FIRST occurrence of '''
after the opening fence — so when the extracted JSON itself contains literal
triple-backtick characters (e.g. facts about code fence formatting), the split
matches those inner backticks and truncates the JSON mid-string.
Replace with line-based fence detection that only matches fences at line
boundaries per the markdown spec. Inner backticks inside JSON string values
are preserved since they aren't at line boundaries.
Member
|
thanks for this! just had to add a test. merging |
This was referenced Jul 7, 2026
benfrank241
added a commit
that referenced
this pull request
Jul 7, 2026
…ON (#2610) Grafts the parse-validated fallback from #2557 onto the line-based fence stripper merged in #2563: after stripping, if the candidate is not valid JSON (partial/absent fence, prose-wrapped or truncated output), fall back to the outermost parseable {..}/[..] span. Never returns a worse candidate than the raw content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation uses
content.split("```json")[1].split("```")[0]to strip markdown code fences. This finds the first```after the opening fence — so when the extracted JSON itself contains literal triple-backtick characters, the split matches those inner backticks and truncates the JSON mid-string.When this bites: Hindsight's fact-extraction LLM produces output wrapped in
```json ... ```fences. If one of the extracted facts describes code fence behavior (e.g. "the model wraps output injson fences"), the JSON now contains `jsonas a literal string value, andsplit("```")finds that inner occurrence. Result: truncated JSON →json.loads` fails → retry loop (up to 4 retries per chunk).The fix replaces string-splitting with line-based fence detection. Per the markdown spec, code fences must appear at the start of a line. Inner triple backticks inside JSON string values are preserved because they aren't at line boundaries.
Before (broken):
After (fixed):
Edge cases: normal fences ✓, inner backticks preserved ✓, no fences no-op ✓, opening-only (truncated output) returned unchanged ✓, text around fence block handled correctly ✓.