Skip to content

Record refresh mental model outcome metadata#2621

Closed
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:rios/refresh-mm-outcome-metadata
Closed

Record refresh mental model outcome metadata#2621
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:rios/refresh-mm-outcome-metadata

Conversation

@koriyoshi2041

Copy link
Copy Markdown
Contributor

Summary

  • add outcome metadata for completed async mental-model refresh operations
  • record content length, populated-content signal, and based_on counts by fact type
  • keep submit-time metadata such as mental_model_id/name intact

Closes #2605

Test

  • uv run --with socksio pytest tests/test_mental_model_scheduled_refresh.py::test_async_refresh_writes_outcome_metadata -q -n0
  • uv run ruff format --check hindsight_api/engine/memory_engine.py hindsight_api/engine/operation_metadata.py tests/test_mental_model_scheduled_refresh.py
  • uv run ruff check hindsight_api/engine/memory_engine.py hindsight_api/engine/operation_metadata.py tests/test_mental_model_scheduled_refresh.py
  • git diff --check

@koriyoshi2041

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #2627. That PR covers the same result_metadata parity gap and adds the no-answer stub boundary, which is a better fit for #2605 than keeping two overlapping implementations open.

I also checked #2627 locally with git diff --check and the focused refresh tests; see the validation comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refresh_mental_model result_metadata lacks semantic outcome fields (retain ops have them since 0.8.x)

1 participant