Remove windows-sys dependency and use direct Win32 bindings#7
Merged
Conversation
Replace the windows-sys crate with a small src/winapi.rs module that re-declares only the handful of Win32/NT types, constants, and functions this crate actually calls. This trims the build graph (no windows-targets/import-libs pulled in transitively), keeps the public API unchanged, and links directly against kernel32 + advapi32 (using the K32-prefixed exports in kernel32 so psapi.lib isn't required). https://claude.ai/code/session_01P8FHocv1oVuMhaZfsCgMpm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR eliminates the
windows-sysdependency by introducing a customwinapimodule that declares only the Win32 types, constants, and functions actually used by this crate. This reduces external dependencies while maintaining full functionality.Key Changes
New
src/winapi.rsmodule: Contains direct Win32/NT bindings with#[repr(C)]-compatible definitions for:HANDLE,HMODULE,BOOL,FARPROC)LUID,TOKEN_ELEVATION,TOKEN_PRIVILEGES, etc.)kernel32.dllandadvapi32.dllUpdated imports across codebase: Replaced all
windows-sysimports withcrate::winapiequivalents in:src/lib.rs:is_process_elevated()andset_debug_privilege()functionssrc/handles.rs: Process and file handle operationssrc/ntapi.rs: NT API wrapper functionsRemoved
windows-sysdependency: Deleted the entire[target.'cfg(windows)'.dependencies]section fromCargo.tomlImplementation Details
extern "system",#[link]attributes)#[repr(C)]https://claude.ai/code/session_01P8FHocv1oVuMhaZfsCgMpm