feat: migrate to Taskfile, fix TUI refresh, handle locked store (#6)

Replace Makefile with Taskfile.yml
Reorder Domains.Update so refreshRows runs after table.Update
Translate bbolt timeout to store.ErrLocked with clear CLI message

Author: venkatkrishna07

Makefile

@@ -71,7 +71,7 @@ xattr -d com.apple.quarantine ./mkdev
 ```sh
 git clone https://github.com/venkatkrishna07/mkdev.git
 cd mkdev
-make build
+task build
 cp bin/mkdev ~/bin/        # or /usr/local/bin
 ```
 

README.md

@@ -0,0 +1,61 @@
+version: '3'
+
+vars:
+  BIN: bin/mkdev
+  PKG: ./...
+  GOFLAGS: -trimpath
+  VERSION:
+    sh: git describe --tags --dirty --always 2>/dev/null || echo "dev"
+  COMMIT:
+    sh: git rev-parse --short HEAD 2>/dev/null || echo "none"
+  DATE:
+    sh: date -u +%Y-%m-%dT%H:%M:%SZ
+  LDFLAGS: >-
+    -X github.com/venkatkrishna07/mkdev/internal/version.Version={{.VERSION}}
+    -X github.com/venkatkrishna07/mkdev/internal/version.Commit={{.COMMIT}}
+    -X github.com/venkatkrishna07/mkdev/internal/version.Date={{.DATE}}
+
+tasks:
+  default:
+    desc: List tasks
+    cmds:
+      - task --list
+
+  build:
+    desc: Build mkdev binary
+    cmds:
+      - mkdir -p bin
+      - go build {{.GOFLAGS}} -ldflags "{{.LDFLAGS}}" -o {{.BIN}} ./cmd/mkdev
+
+  test:
+    desc: Run tests with race detector
+    cmds:
+      - go test {{.GOFLAGS}} -race -count=1 -timeout=60s {{.PKG}}
+
+  lint:
+    desc: Run golangci-lint
+    cmds:
+      - golangci-lint run
+
+  run:
+    desc: Build and run mkdev
+    deps: [build]
+    cmds:
+      - "{{.BIN}}"
+
+  coverage:
+    desc: Run tests with coverage report
+    cmds:
+      - go test {{.GOFLAGS}} -race -count=1 -coverprofile=coverage.txt -covermode=atomic {{.PKG}}
+      - go tool cover -func=coverage.txt | tail -1
+
+  tidy:
+    desc: Tidy modules and format code
+    cmds:
+      - go mod tidy
+      - gofmt -w .
+
+  clean:
+    desc: Remove build artifacts
+    cmds:
+      - rm -rf bin coverage.txt

Taskfile.yml

@@ -1,11 +1,14 @@
 package cli
 
 import (
+	"errors"
+	"fmt"
 	"log/slog"
 	"os"
 	"path/filepath"
 
 	"github.com/spf13/cobra"
+	"github.com/venkatkrishna07/mkdev/internal/store"
 	"github.com/venkatkrishna07/mkdev/internal/version"
 )
 
@@ -55,6 +58,11 @@ func New() *cobra.Command {
 // Execute runs the root command and returns its exit code.
 func Execute() int {
 	if err := New().Execute(); err != nil {
+		if errors.Is(err, store.ErrLocked) {
+			fmt.Fprintln(os.Stderr, "mkdev: another instance is already running (state.db is locked).")
+			fmt.Fprintln(os.Stderr, "       quit the running instance and try again.")
+			return 1
+		}
 		slog.Error("command failed", "err", err)
 		return 1
 	}

internal/cli/root.go

@@ -8,13 +8,17 @@ import (
 	"time"
 
 	bolt "go.etcd.io/bbolt"
+	bolterrors "go.etcd.io/bbolt/errors"
 )
 
 var bucketRoutes = []byte("routes")
 
 // ErrNotFound is returned when a record does not exist.
 var ErrNotFound = errors.New("store: not found")
 
+// ErrLocked is returned when the database file is held by another process.
+var ErrLocked = errors.New("store: database locked by another process")
+
 // Store wraps a bbolt database.
 type Store struct {
 	db *bolt.DB
@@ -27,6 +31,9 @@ func Open(path string) (*Store, error) {
 	}
 	db, err := bolt.Open(path, 0o600, &bolt.Options{Timeout: 2 * time.Second})
 	if err != nil {
+		if errors.Is(err, bolterrors.ErrTimeout) {
+			return nil, fmt.Errorf("%w: %s", ErrLocked, path)
+		}
 		return nil, fmt.Errorf("store: open %s: %w", path, err)
 	}
 	err = db.Update(func(tx *bolt.Tx) error {

internal/store/store.go

@@ -114,6 +114,8 @@ func (d Domains) Init() tea.Cmd { return nil }
 
 // Update handles route refresh and window-size events.
 func (d Domains) Update(in tea.Msg) (Domains, tea.Cmd) {
+	var cmd tea.Cmd
+	d.table, cmd = d.table.Update(in)
 	switch m := in.(type) {
 	case msg.RoutesRefreshed:
 		d.routes = m.Routes
@@ -126,8 +128,6 @@ func (d Domains) Update(in tea.Msg) (Domains, tea.Cmd) {
 		d.table.SetWidth(tableTotalWidth(cols))
 		d.fitHeight()
 	}
-	var cmd tea.Cmd
-	d.table, cmd = d.table.Update(in)
 	return d, cmd
 }