Add an automatic module name to the MANIFEST

[LonelyMidoriya]

Summary by CodeRabbit

• Chores
  • Added Automatic-Module-Name entries to JAR manifests for core and XMP-core to improve module identification.
  • Bumped parent project version from 1.29.1 to 1.29.6.
  • Packaging/manifest-only changes; no runtime behavior or dependencies were modified.

[coderabbitai]

Walkthrough

Added maven-jar-plugin manifest entries to two module POMs to set Automatic-Module-Name values (org.verapdf.core and org.verapdf.xmp.core), and updated the root POM parent version from 1.29.1 to 1.29.6. No code, resource, or dependency changes.

Changes

Cohort / File(s)	Summary
Module manifest entries core/pom.xml, xmp-core/pom.xml	Added maven-jar-plugin configuration under <build><plugins> with <archive><manifestEntries><Automatic-Module-Name> set to org.verapdf.core and org.verapdf.xmp.core respectively. No other functional changes.
Parent version update pom.xml	Bumped project parent version from 1.29.1 to 1.29.6. No other changes to plugins or manifest settings in this file.

Sequence Diagram(s)

(omitted — changes are build/manifest metadata only; no runtime/control-flow modifications)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–15 minutes

• Verify correct placement of the maven-jar-plugin configuration under each module's <build><plugins>.
• Confirm the exact Automatic-Module-Name strings in core/pom.xml and xmp-core/pom.xml.
• Check the parent version change in pom.xml and ensure no unintended edits elsewhere.

Poem

🐇 I slipped a name into each jar with care,
Little labels for modules to wear.
Manifests whisper, neat and true,
Hopping through builds — a rabbit's cue. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding Automatic-Module-Name entries to the MANIFEST across multiple POM files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch automatic-module-name

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34f59bf and 5b16ad6.

📒 Files selected for processing (1)

• pom.xml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• pom.xml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Quality Assurance
• GitHub Check: Codacy Static Code Analysis

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecf7c61 and 095b7b8.

📒 Files selected for processing (2)

• core/pom.xml (1 hunks)
• xmp-core/pom.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (3)

xmp-core/pom.xml (1)

25-39: Module name hierarchy is appropriate.

The Automatic-Module-Name org.verapdf.xmp.core logically extends the base org.verapdf.core module name, reflecting the module's role as XMP-specific core functionality. This naming hierarchy is consistent and follows Java module conventions.

core/pom.xml (2)

121-133: Unable to verify - pom.xml files not found in repository.

The verification scripts could not locate any pom.xml files in the repository, which contradicts the review comment's reference to core/pom.xml (lines 121-133).

Before proceeding, manually verify:

• The file core/pom.xml exists in the repository
• The parent POM (verapdf-library) defines maven-jar-plugin version in its <pluginManagement> section to ensure consistent versioning across all modules

---

128-128: No action required—Automatic-Module-Name is appropriate and necessary.

Verification confirms no module-info.java exists anywhere in the project. Since the explicit module descriptor is absent, the Automatic-Module-Name entry in the manifest is the correct and necessary fallback for JPMS metadata. The module name follows proper Java naming conventions and is consistent with the xmp-core module in the same project.