Skip to content

test: cover UTF-8 file pipe regressions#243

Open
EfeDurmaz16 wants to merge 1 commit into
vercel-labs:mainfrom
EfeDurmaz16:efe/utf8-pipe-regressions
Open

test: cover UTF-8 file pipe regressions#243
EfeDurmaz16 wants to merge 1 commit into
vercel-labs:mainfrom
EfeDurmaz16:efe/utf8-pipe-regressions

Conversation

@EfeDurmaz16
Copy link
Copy Markdown
Contributor

Summary

Adds regression coverage for the UTF-8 file-read cases discussed in #242:

  • jq file input redirected to a file preserves multibyte text
  • custom commands can decode multibyte stdin piped from cat
  • custom-command example docs now show decodeBytesToUtf8(ctx.stdin) for text operations

Verification

  • pnpm --dir packages/just-bash exec vitest run src/commands/jq/jq.utf8-stdin.test.ts src/custom-commands.test.ts
  • pnpm --filter just-bash typecheck
  • pnpm lint
  • pnpm --filter just-bash knip
  • pnpm --filter just-bash build

Refs #242

@EfeDurmaz16 EfeDurmaz16 requested a review from cramforce as a code owner May 15, 2026 10:26
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@CodyWatters
Copy link
Copy Markdown

Great find! just ran into this - thanks for opening this pr

@cramforce
Copy link
Copy Markdown
Contributor

Looks great. Please sign your commit and run pnpm changeset!

@EfeDurmaz16
Copy link
Copy Markdown
Contributor Author

Thanks! I’ll sign the commit and add a changeset now.

@EfeDurmaz16 EfeDurmaz16 force-pushed the efe/utf8-pipe-regressions branch from 4170561 to 5814e10 Compare May 15, 2026 20:26
@EfeDurmaz16
Copy link
Copy Markdown
Contributor Author

Done. Added the changeset and updated the PR to use a verified signed commit.

@EfeDurmaz16 EfeDurmaz16 force-pushed the efe/utf8-pipe-regressions branch from 5814e10 to ed6c6d7 Compare May 16, 2026 02:50
@EfeDurmaz16
Copy link
Copy Markdown
Contributor Author

Done. I amended the commit with Signed-off-by and confirmed the changeset is present via pnpm exec changeset status --since=c08352c.

I also re-ran the focused regression coverage for this PR:

  • pnpm --filter just-bash exec vitest run src/commands/jq/jq.utf8-stdin.test.ts src/custom-commands.test.ts
  • pnpm exec biome check .changeset/dry-worms-mix.md examples/custom-command/README.md packages/just-bash/src/commands/jq/jq.utf8-stdin.test.ts packages/just-bash/src/custom-commands.test.ts

The remaining red checks are Vercel preview deployment authorization checks.

@cramforce
Copy link
Copy Markdown
Contributor

Please re-push with a signed commit

Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
@EfeDurmaz16 EfeDurmaz16 force-pushed the efe/utf8-pipe-regressions branch from ed6c6d7 to cd4f1a5 Compare May 24, 2026 19:47
@EfeDurmaz16
Copy link
Copy Markdown
Contributor Author

Re-pushed with a GitHub-verified SSH-signed commit: cd4f1a5. No content changes beyond rewriting the commit signature. The remaining red checks are Vercel deployment authorization checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants