Export built-in commands for composition#303
Open
boramuyar wants to merge 2 commits into
Open
Conversation
|
@boramuyar is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBuiltinCommandsfrom the public package entry pointMotivation
Custom commands can override built-ins, but there is currently no supported way to delegate back to the original built-in implementation. Consumers that need to instrument a command or substitute part of its
CommandContextmust either construct a nestedBashinstance or copy the command implementation.This exposes the registry's existing lazy command factory under a public composition-oriented name, allowing consumers to decorate built-ins while retaining their implementation and execution context.
Validation
pnpm --filter just-bash typecheckpnpm --filter just-bash knip