fix(ai): type legacy tool callbacks on agents#15588
Open
he-yufeng wants to merge 2 commits into
Open
Conversation
Author
|
Updated this branch to wire legacy experimental_onToolCallStart and experimental_onToolCallFinish through ToolLoopAgent.generate() and .stream(), with regression coverage for both start/finish callbacks on generate and stream. Validation: ultracite check passed; pnpm --filter ai test:node src/agent/tool-loop-agent.test.ts passed (103 tests); pnpm --filter ai type-check passed; git diff --check passed. The remaining Vercel deployment check still appears to be the team authorization gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
ToolLoopAgent.generate()andToolLoopAgent.stream()forward extra call options intogenerateText()andstreamText(). The legacyexperimental_onToolCallStartandexperimental_onToolCallFinishcallbacks therefore work at runtime, but the agent call parameter type did not expose them.That left consumers needing
as anyfor callbacks that the underlying text APIs still support.Summary
AgentCallParametersonToolExecutionStart/onToolExecutionEndfieldsgenerate()andstream()in the agent d.ts testaiManual Verification
Checklist
pnpm changesetin the project root)Related Issues
Fixes #14278