[codex] fix state-pg setIfNotExists TTL expiry#636
Draft
Zygimantass wants to merge 1 commit into
Draft
Conversation
Contributor
|
@Zygimantass is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Postgres state adapter so
setIfNotExists()can claim a cache key whose existing row has expired.Previously the method used
ON CONFLICT DO NOTHING, so an expired row inchat_state_cachestill blocked acquisition until a separate cleanup deleted it. That diverged from the memory adapter behavior and from the expected lease semantics for cache-backed coordination.The new query keeps active rows protected, but replaces rows whose
expires_atis in the past.Validation
pnpm --filter @chat-adapter/state-pg testpnpm --filter @chat-adapter/state-pg typecheckpnpm exec ultracite check packages/state-pg/src/index.ts packages/state-pg/src/index.test.ts