fix(eslint-plugin-next): support custom pageExtensions in no-html-link-for-pages rule#92980
Open
Jah-yee wants to merge 1 commit intovercel:canaryfrom
Open
fix(eslint-plugin-next): support custom pageExtensions in no-html-link-for-pages rule#92980Jah-yee wants to merge 1 commit intovercel:canaryfrom
Jah-yee wants to merge 1 commit intovercel:canaryfrom
Conversation
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| fsReadDirSyncCache[directory] ??= fs.readdirSync(directory, { | ||
| withFileTypes: true, | ||
| }) | ||
| const extPattern = extensions.map((ext) => ext.replace('.', '\\.')).join('|') | ||
| const extRegex = new RegExp(`\\.(\\${extPattern})$`) |
Contributor
There was a problem hiding this comment.
Extra backslash before in extRegex creates unintended regex escape sequences for custom extensions starting with s, d, w, b, etc.
…ages rule The no-html-link-for-pages rule was using hardcoded regex patterns /(\.(j|t)sx?)$/ to detect page files, ignoring the pageExtensions configured in next.config.js. This change: - Reads pageExtensions from context.settings.next.pageExtensions - Passes pageExtensions to getUrlFromPagesDirectories and getUrlFromAppDirectory - Updates parseUrlForPages and parseUrlForAppDir to build dynamic regex patterns from the configured extensions - Defaults to ['jsx', 'js', 'ts', 'tsx'] when no pageExtensions is set Fixes vercel#53473
Jah-yee
force-pushed
the
fix/no-html-link-for-pages-pageextensions
branch
from
bc5582f to
2cedd40
Compare
This was referenced Apr 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Summary
The
@next/next/no-html-link-for-pagesESLint rule previously only recognized pages withjs,jsx,ts, andtsxextensions. It ignored custompageExtensionsconfigured innext.config.js(e.g.,.mdx).Root Cause
The rule uses
parseUrlForPages()andparseUrlForAppDir()inpackages/eslint-plugin-next/src/utils/url.ts, which hardcoded the regex instead of reading from the project'snext.config.js.Fix
getPageExtensions()utility that loadspageExtensionsfrom the project'snext.config.js(with fallback to defaults)parseUrlForPages()andparseUrlForAppDir()to accept an optionalextensionsparameterFiles Changed
packages/eslint-plugin-next/src/utils/get-page-extensions.ts(new)packages/eslint-plugin-next/src/utils/url.tspackages/eslint-plugin-next/src/rules/no-html-link-for-pages.tsTesting
Manually verified with a test case using custom
pageExtensions(e.g.,pageExtensions: ['mdx']).Warmly, RoomWithOutRoof