Skip to content

draft: chore(CI): Remove global npm installs of napi CLI #92983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bgw wants to merge 1 commit into
base: canary
Choose a base branch
from
+9 −4
Draft

draft: chore(CI): Remove global npm installs of napi CLI #92983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ jobs:
echo "Rustc binary: $(file $(which rustc) || echo 'not found')"
rustc --version --verbose || true
node -v
npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}"
pnpm install --frozen-lockfile --filter @next/swc
TURBO_CACHE_FLAG="${NEXT_SKIP_BUILD_CACHE:+--force}"
pnpm dlx turbo@${TURBO_VERSION} run ${{ matrix.build_task }} ${TURBO_ARGS} ${TURBO_CACHE_FLAG} -- --target ${{ matrix.target }}
if [ "${{ matrix.os }}" != "windows" ]; then
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
needs: ['changes']
if: ${{ needs.changes.outputs.docs-only == 'false' }}
with:
needsRust: 'yes'
skipInstallBuild: 'yes'
stepName: 'build-native'
uploadNativeArtifact: 'next-swc-linux'
Expand All @@ -80,6 +81,7 @@ jobs:
needs: ['changes']
if: ${{ needs.changes.outputs.docs-only == 'false' }}
with:
needsRust: 'yes'
skipInstallBuild: 'yes'
stepName: 'build-native-windows'
runs_on_labels: '["windows","self-hosted","x64"]'
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/build_reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ on:
type: string
default: 'chromium'
env:
NAPI_CLI_VERSION: 2.18.4
TURBO_VERSION: 2.9.4
TURBO_ARGS: '-v --env-mode loose --remote-cache-timeout 300 --log-order stream'
NODE_LTS_VERSION: 20.9.0
Expand Down Expand Up @@ -252,7 +251,7 @@ jobs:
- run: rustc --version
if: ${{ (inputs.uploadNativeArtifact != '') || inputs.needsNextest == 'yes' || inputs.needsRust == 'yes' }}

- run: corepack prepare --activate yarn@1.22.19 && npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}"
- run: corepack prepare --activate yarn@1.22.19

# clean up any previous artifacts to avoid hitting disk space limits
- run: git clean -xdf && rm -rf /tmp/next-repo-*; rm -rf /tmp/next-install-* /tmp/yarn-* /tmp/ncc-cache target
Expand Down Expand Up @@ -304,9 +303,13 @@ jobs:
- run: git checkout .
if: ${{ inputs.skipInstallBuild != 'yes' }}

- run: pnpm install
- run: pnpm install --frozen-lockfile
if: ${{ inputs.skipInstallBuild != 'yes' }}

# run a minimal install to make sure we pick up the napi CLI
- run: pnpm install --frozen-lockfile --ignore-scripts --filter @next/swc
if: ${{ inputs.skipInstallBuild == 'yes' && inputs.needsRust == 'yes' }}

- name: Install node-file-trace test dependencies
if: ${{ inputs.needsNextest == 'yes' }}
working-directory: turbopack/crates/turbopack-tracing/tests/node-file-trace
Expand Down
Loading