turbo-tasks-backend: fix snapshot coordination races + extract SnapshotCoordinator#93416
Merged
lukesandberg merged 6 commits intocanaryfrom May 4, 2026
Merged
turbo-tasks-backend: fix snapshot coordination races + extract SnapshotCoordinator#93416lukesandberg merged 6 commits intocanaryfrom
lukesandberg merged 6 commits intocanaryfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
created-by: Turbopack team
lukesandberg
commented
May 1, 2026
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: d2bde2d |
Contributor
Tests PassedCommit: d2bde2d |
lukesandberg
force-pushed
the
slightly_more_crash_safety
branch
from
d9b6bc0 to
7375dff
Compare
This was referenced May 1, 2026
lukesandberg
changed the title
lukesandberg
force-pushed
the
slightly_more_crash_safety
branch
from
23b712c to
4378987
Compare
bgw
approved these changes
May 4, 2026
sokra
reviewed
May 4, 2026
sokra
reviewed
May 4, 2026
lukesandberg
force-pushed
the
slightly_more_crash_safety
branch
from
4378987 to
d2bde2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold a lock while persisting so two snapshots cannot execute concurrently
stopis called while an idle snapshot is running, then snapshotting can race with itself, this can corrupt the use of thein_progress_operationsparameter since two threads willfetch_orwith it and wait for the bit to be clearedAbort the process if
panic!occurs during task spawningtry_start_task_executionpanics it ends up hanging a task which can deadlock the process, in this case we have no better option than to just log and abort.