Skip to content

[Node Streams] Use node:stream/consumers#94963

Open
lubieowoce wants to merge 1 commit into
canaryfrom
lubieowoce/node-stream-consumers
Open

[Node Streams] Use node:stream/consumers#94963
lubieowoce wants to merge 1 commit into
canaryfrom
lubieowoce/node-stream-consumers

Conversation

@lubieowoce

Copy link
Copy Markdown
Member

Converting a node stream to a ReadableStream just to collect it into a buffer seems a bit inefficient

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Stats cancelled

Commit: 6d235cd
View workflow run

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 6d235cd | About building and testing Next.js

pnpm test-dev test/development/app-dir/hmr-intercept-routes/hmr-intercept-routes.test.ts (job)

  • hmr-intercept-routes > should update intercept routes via HMR (DD)
Expand output

● hmr-intercept-routes › should update intercept routes via HMR

page.waitForSelector: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('#default-intercept') to be visible

  569 |
  570 |     return this.startChain(async () => {
> 571 |       const el = await page.waitForSelector(selector, {
      |                             ^
  572 |         timeout,
  573 |         state,
  574 |       })

  at waitForSelector (lib/browsers/playwright.ts:571:29)
  at Playwright._chain (lib/browsers/playwright.ts:701:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:682:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:570:17)
  at Object.waitForElementByCss (development/app-dir/hmr-intercept-routes/hmr-intercept-routes.test.ts:38:21)

@eps1lon

eps1lon commented Jun 22, 2026

Copy link
Copy Markdown
Member

Why not use the built-in helpers everywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants