Skip to content

use latest OTEL collector and switch Jaeger to OTLP protocol #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stoty wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

use latest OTEL collector and switch Jaeger to OTLP protocol #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
OTELCOL_IMG=otel/opentelemetry-collector:0.67.0
OTELCOL_IMG=otel/opentelemetry-collector:latest
OTELCOL_ARGS=
2 changes: 2 additions & 0 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ services:
restart: always
ports:
- "16686:16686"
- "16685:16685"
- "14268"
- "14250"
- "4317"

# Zipkin
zipkin-all-in-one:
Expand Down
6 changes: 3 additions & 3 deletions otel-collector-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ exporters:
endpoint: "http://zipkin-all-in-one:9411/api/v2/spans"
format: proto

jaeger:
endpoint: jaeger-all-in-one:14250
otlp/jaeger:
endpoint: jaeger-all-in-one:4317

@maniraj1234 maniraj1234 Nov 10, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there is a change in port? I guess they have purposefully kept it 14250 to support nextJS framework.

@stoty stoty Nov 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly I don't know the nextJS framework.
New Jaeger versions support the OTLP protocol natively, and use that for communication with the OTEL collector, while in older version the collector used the Jaeger protocol to talk to Jaeger.

This port is not supposed to be seen or used by the observer application.

@jprokay-tb jprokay-tb Nov 30, 2023 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. For further context: https://opentelemetry.io/blog/2023/jaeger-exporter-collector-migration/

tls:
insecure: true

Expand All @@ -37,7 +37,7 @@ service:
traces:
receivers: [otlp]
processors: [batch]
exporters: [logging, zipkin, jaeger]
exporters: [logging, zipkin, otlp/jaeger]
metrics:
receivers: [otlp]
processors: [batch]
Expand Down