type: move mutate type annotation into useCallback generic#4191
Open
li-jia-nan wants to merge 3 commits into
Open
type: move mutate type annotation into useCallback generic#4191li-jia-nan wants to merge 3 commits into
li-jia-nan wants to merge 3 commits into
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Pull request overview
Refactors the boundMutate type definition inside the core useSWRHandler implementation by moving the type annotation from the variable declaration to the useCallback generic. This keeps boundMutate typed as SWRResponse<Data, Error>['mutate'] while leaving runtime behavior unchanged.
Changes:
- Move
boundMutatetype annotation intouseCallback<...>generic to keep the callback result typed correctly. - Keep
boundMutate’s public type aligned withSWRResponse<Data, Error>['mutate']without changing the callback body.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boundMutatetype definition