Remove "workflow/internal/serialization" export (#1082)

TooTallNate · vercel[bot] · web-flow · commit 0946dad01b5d · 2026-02-16T11:50:57.000-08:00
* Remove "workflow/internal/serialization" export

Was only being used in these two e2e test files and the data being passed in those tests don't rely on any specialized data types, so just use JSON there.

* Fix: Removing the `workflow/internal/serialization` export from package.json breaks 5 files in `packages/world-testing` that still import `hydrateWorkflowReturnValue` from that path.

Co-authored-by: TooTallNate &lt;n@n8.io&gt;

* lockfile

---------

Co-authored-by: Vercel &lt;vercel[bot]@users.noreply.github.com&gt;
diff --git a/.changeset/cyan-ravens-eat.md b/.changeset/cyan-ravens-eat.md
@@ -0,0 +1,5 @@
+---
+"workflow": patch
+---
+
+Remove "workflow/internal/serialization" export
diff --git a/packages/workflow/package.json b/packages/workflow/package.json
@@ -38,7 +38,6 @@
       "default": "./dist/api.js"
     },
     "./internal/errors": "./dist/internal/errors.js",
-    "./internal/serialization": "./dist/internal/serialization.js",
     "./internal/builtins": "./dist/internal/builtins.js",
     "./internal/private": "./dist/internal/private.js",
     "./internal/class-serialization": "./dist/internal/class-serialization.js",
diff --git a/packages/workflow/src/internal/serialization.ts b/packages/workflow/src/internal/serialization.ts
diff --git a/packages/world-testing/package.json b/packages/world-testing/package.json
@@ -24,6 +24,7 @@
   "dependencies": {
     "@hono/node-server": "1.19.5",
     "@workflow/cli": "workspace:*",
+    "@workflow/core": "workspace:*",
     "workflow": "workspace:*",
     "@workflow/world": "workspace:*",
     "chalk": "5.6.2",
diff --git a/packages/world-testing/src/addition.mts b/packages/world-testing/src/addition.mts
@@ -1,5 +1,5 @@
 import { expect, test, vi } from 'vitest';
-import { hydrateWorkflowReturnValue } from 'workflow/internal/serialization';
+import { hydrateWorkflowReturnValue } from '@workflow/core/serialization';
 import { createFetcher, startServer } from './util.mjs';
 
 export function addition(world: string) {
diff --git a/packages/world-testing/src/errors.mts b/packages/world-testing/src/errors.mts
@@ -1,5 +1,5 @@
 import { expect, test, vi } from 'vitest';
-import { hydrateWorkflowReturnValue } from 'workflow/internal/serialization';
+import { hydrateWorkflowReturnValue } from '@workflow/core/serialization';
 import { createFetcher, startServer } from './util.mjs';
 
 export function errors(world: string) {
diff --git a/packages/world-testing/src/hooks.mts b/packages/world-testing/src/hooks.mts
@@ -1,5 +1,5 @@
 import { expect, test, vi } from 'vitest';
-import { hydrateWorkflowReturnValue } from 'workflow/internal/serialization';
+import { hydrateWorkflowReturnValue } from '@workflow/core/serialization';
 import type { Hook } from '../workflows/hooks.ts';
 import { jsonlines } from './jsonlines.mjs';
 import { createFetcher, startServer } from './util.mjs';
diff --git a/packages/world-testing/src/idempotency.mts b/packages/world-testing/src/idempotency.mts
@@ -1,5 +1,5 @@
 import { expect, test, vi } from 'vitest';
-import { hydrateWorkflowReturnValue } from 'workflow/internal/serialization';
+import { hydrateWorkflowReturnValue } from '@workflow/core/serialization';
 import { createFetcher, startServer } from './util.mjs';
 
 export function idempotency(world: string) {
diff --git a/packages/world-testing/src/null-byte.mts b/packages/world-testing/src/null-byte.mts
@@ -1,5 +1,5 @@
 import { expect, test, vi } from 'vitest';
-import { hydrateWorkflowReturnValue } from 'workflow/internal/serialization';
+import { hydrateWorkflowReturnValue } from '@workflow/core/serialization';
 import { createFetcher, startServer } from './util.mjs';
 
 export function nullByte(world: string) {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/workbench/nextjs-turbopack/pages/api/trigger-pages.ts b/workbench/nextjs-turbopack/pages/api/trigger-pages.ts
@@ -4,25 +4,8 @@ import {
   WorkflowRunFailedError,
   WorkflowRunNotCompletedError,
 } from 'workflow/internal/errors';
-import { hydrateWorkflowArguments } from 'workflow/internal/serialization';
 import { allWorkflows } from '@/_workflows';
 
-// Disable body parsing to receive raw binary data
-export const config = {
-  api: {
-    bodyParser: false,
-  },
-};
-
-async function readRawBody(req: NextApiRequest): Promise<Buffer> {
-  return new Promise((resolve, reject) => {
-    const chunks: Buffer[] = [];
-    req.on('data', (chunk: Buffer) => chunks.push(chunk));
-    req.on('end', () => resolve(Buffer.concat(chunks)));
-    req.on('error', reject);
-  });
-}
-
 export default async function handler(
   req: NextApiRequest,
   res: NextApiResponse
@@ -77,14 +60,11 @@ async function handlePost(req: NextApiRequest, res: NextApiResponse) {
       const num = parseFloat(arg);
       return Number.isNaN(num) ? arg.trim() : num;
     });
+  } else if (req.body && Array.isArray(req.body)) {
+    // Args from JSON body
+    args = req.body;
   } else {
-    // Args from body (binary serialized data)
-    const buffer = await readRawBody(req);
-    if (buffer.byteLength > 0) {
-      args = hydrateWorkflowArguments(new Uint8Array(buffer), globalThis);
-    } else {
-      args = [42];
-    }
+    args = [42];
   }
   console.log(`Starting "${workflowFn}" workflow with args: ${args}`);
 
diff --git a/workbench/nextjs-webpack/pages/api/trigger-pages.ts b/workbench/nextjs-webpack/pages/api/trigger-pages.ts
@@ -4,25 +4,8 @@ import {
   WorkflowRunFailedError,
   WorkflowRunNotCompletedError,
 } from 'workflow/internal/errors';
-import { hydrateWorkflowArguments } from 'workflow/internal/serialization';
 import { allWorkflows } from '@/_workflows';
 
-// Disable body parsing to receive raw binary data
-export const config = {
-  api: {
-    bodyParser: false,
-  },
-};
-
-async function readRawBody(req: NextApiRequest): Promise<Buffer> {
-  return new Promise((resolve, reject) => {
-    const chunks: Buffer[] = [];
-    req.on('data', (chunk: Buffer) => chunks.push(chunk));
-    req.on('end', () => resolve(Buffer.concat(chunks)));
-    req.on('error', reject);
-  });
-}
-
 export default async function handler(
   req: NextApiRequest,
   res: NextApiResponse
@@ -77,14 +60,11 @@ async function handlePost(req: NextApiRequest, res: NextApiResponse) {
       const num = parseFloat(arg);
       return Number.isNaN(num) ? arg.trim() : num;
     });
+  } else if (req.body && Array.isArray(req.body)) {
+    // Args from JSON body
+    args = req.body;
   } else {
-    // Args from body (binary serialized data)
-    const buffer = await readRawBody(req);
-    if (buffer.byteLength > 0) {
-      args = hydrateWorkflowArguments(new Uint8Array(buffer), globalThis);
-    } else {
-      args = [42];
-    }
+    args = [42];
   }
   console.log(`Starting "${workflowFn}" workflow with args: ${args}`);
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"workflow": patch
 +---
++
 +Remove "workflow/internal/serialization" export