wip: added location integration tests

Author: tamirse

datacrunch/instances/instances.py

@@ -427,7 +427,7 @@ def action(self, id_list: Union[List[str], str], action: str, volume_ids: Option
         return
 
     # TODO: use enum/const for location_code
-    def is_available(self, instance_type: str, is_spot: bool = None, location_code: str = None) -> bool:
+    def is_available(self, instance_type: str, is_spot: bool = False, location_code: str = None) -> bool:
         """Returns True if a specific instance type is now available for deployment
 
         :param instance_type: instance type
@@ -439,7 +439,7 @@ def is_available(self, instance_type: str, is_spot: bool = None, location_code:
         :return: True if available to deploy, False otherwise
         :rtype: bool
         """
-        is_spot = str(is_spot).lower() if is_spot is not None else None
+        is_spot = str(is_spot).lower()
         query_params = {'isSpot': is_spot, 'location_code': location_code}
         url = f'/instance-availability/{instance_type}'
         return self._http_client.get(url, query_params).json()

tests/integration_tests/test_locations.py

@@ -0,0 +1,65 @@
+import os
+import pytest
+from datacrunch.datacrunch import DataCrunchClient
+from datacrunch.constants import Locations
+
+IN_GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS") == "true"
+
+location_codes = [Locations.FIN_01, Locations.ICE_01]
+
+
+@pytest.mark.skipif(IN_GITHUB_ACTIONS, reason="Test doesn't work in Github Actions.")
+@pytest.mark.withoutresponses
+class TestLocations():
+
+    def test_specific_instance_availability_in_specific_location(self, datacrunch_client: DataCrunchClient):
+        # call the instance availability endpoint, for a specific location
+        availability = datacrunch_client.instances.is_available(
+            'CPU.4V', location_code=Locations.FIN_01)
+
+        assert availability is not None
+        assert isinstance(availability, bool)
+
+    def test_all_availabilies_in_specific_location(self, datacrunch_client: DataCrunchClient):
+
+        # call the instance availability endpoint, for a specific location
+        availabilities = datacrunch_client.instances.get_availabilities(
+            location_code=Locations.FIN_01)
+
+        assert availabilities is not None
+        assert isinstance(availabilities, list)
+        assert len(availabilities) == 1
+        assert availabilities[0]['location_code'] in location_codes
+        assert isinstance(availabilities[0]['availabilities'], list)
+        assert len(availabilities[0]['availabilities']) > 0
+
+    def test_all_availabilites(self, datacrunch_client: DataCrunchClient):
+        # call the instance availability endpoint, for all locations
+        all_availabilities = datacrunch_client.instances.get_availabilities()
+
+        assert all_availabilities is not None
+        assert isinstance(all_availabilities, list)
+        assert len(all_availabilities) > 1
+        assert all_availabilities[0]['location_code'] in location_codes
+        assert all_availabilities[1]['location_code'] in location_codes
+        assert isinstance(all_availabilities[0]['availabilities'], list)
+        assert len(all_availabilities[0]['availabilities']) > 0
+
+    def test_get_all_locations(self, datacrunch_client: DataCrunchClient):
+        # call the locations endpoint
+        locations = datacrunch_client.locations.get()
+
+        assert locations is not None
+        assert isinstance(locations, list)
+
+        assert locations[0]['code'] in location_codes
+        assert locations[1]['code'] in location_codes
+        assert locations[0]['code'] != locations[1]['code']
+
+        assert locations[0]['name'] is not None
+        assert locations[1]['name'] is not None
+        assert locations[0]['name'] != locations[1]['name']
+
+        assert locations[0]['country_code'] is not None
+        assert locations[1]['country_code'] is not None
+        assert locations[0]['country_code'] != locations[1]['country_code']

tests/unit_tests/instances/test_instances.py

@@ -428,7 +428,7 @@ def test_action_failed(self, instances_service, endpoint):
     def test_is_available_successful(self, instances_service):
         # arrange - add response mock
         url = instances_service._http_client._base_url + \
-            '/instance-availability/' + INSTANCE_TYPE
+            '/instance-availability/' + INSTANCE_TYPE + "?isSpot=false"
         responses.add(
             responses.GET,
             url,
@@ -464,7 +464,8 @@ def test_is_spot_available_successful(self, instances_service):
 
     def test_is_available_failed(self, instances_service):
         # arrange - add response mock
-        url = instances_service._http_client._base_url + '/instance-availability/x'
+        url = instances_service._http_client._base_url + \
+            '/instance-availability/x' + "?isSpot=false"
         responses.add(
             responses.GET,
             url,