added codecov badge, added exceptions tests

Author: tamirse

README.md

@@ -4,18 +4,27 @@
   <a href='https://github.com/DataCrunch-io/datacrunch-python/actions?query=workflow%3A%22Unit+Tests%22+branch%3Amaster'>
     <img src='https://github.com/DataCrunch-io/datacrunch-python/workflows/Unit%20Tests/badge.svg'></img>
   </a>
+
   <a href='https://github.com/DataCrunch-io/datacrunch-python/actions?query=workflow%3A%22Code+Style%22+branch%3Amaster'>
     <img src='https://github.com/DataCrunch-io/datacrunch-python/workflows/Code%20Style/badge.svg'></img>
   </a>
+
+  <a href="https://codecov.io/gh/DataCrunch-io/datacrunch-python">
+    <img src="https://codecov.io/gh/DataCrunch-io/datacrunch-python/branch/master/graph/badge.svg?token=5X5KTYSSPK"/>
+  </a>
+
   <a href='https://datacrunch-python.readthedocs.io/en/latest/'>
     <img src='https://readthedocs.org/projects/datacrunch-python/badge/?version=latest'></img>
   </a>
+
   <a href='https://github.com/DataCrunch-io/datacrunch-python/blob/master/LICENSE'>
     <img src='https://img.shields.io/github/license/DataCrunch-io/datacrunch-python'></img>
   </a>
+
   <a href='https://pypi.org/project/datacrunch/'>
     <img src='https://img.shields.io/pypi/v/datacrunch?logo=python&logoColor=green'></img>
   </a>
+
   <a href='https://datacrunch.io'>
     <img src='https://img.shields.io/badge/datacrunch-.io-blue'></img>
   </a>

tests/unit_tests/conftest.py

@@ -7,6 +7,7 @@
 ACCESS_TOKEN = "test-token"
 CLIENT_ID = "0123456789xyz"
 
+
 @pytest.fixture
 def http_client():
     auth_service = Mock()
@@ -15,4 +16,4 @@ def http_client():
     auth_service.refresh = Mock(return_value=None)
     auth_service._client_id = CLIENT_ID
 
-    return HTTPClient(auth_service, BASE_URL)
+    return HTTPClient(auth_service, BASE_URL)

tests/unit_tests/http_client/test_http_client.py

@@ -1,7 +1,6 @@
 import pytest
-import responses # https://github.com/getsentry/responses
+import responses  # https://github.com/getsentry/responses
 from unittest.mock import Mock
-from datacrunch.http_client import http_client
 from datacrunch.exceptions import APIException
 
 INVALID_REQUEST = 'invalid_request'
@@ -10,12 +9,13 @@
 UNAUTHORIZED_REQUEST = 'unauthorized_request'
 UNAUTHORIZED_REQUEST_MESSAGE = 'Access token is missing or invalid'
 
+
 class TestHttpClient:
     def test_add_base_url(self, http_client):
         # arrange
         path = "/test"
         base = http_client._base_url
-        
+
         # act
         url = http_client._add_base_url(path)
 
@@ -31,14 +31,14 @@ def test_generate_bearer_header(self, http_client):
         assert bearer_string == f'Bearer {access_token}'
 
     def test_generate_user_agent(self, http_client):
-        # arrange 
+        # arrange
         version = http_client._version
         client_id_truncated = http_client._auth_service._client_id[0:10]
 
         # act
         user_agent_string = http_client._generate_user_agent()
 
-        # assert 
+        # assert
         assert type(user_agent_string) == str
         assert user_agent_string == f'datacrunch-python-v{version}-{client_id_truncated}'
 
@@ -47,7 +47,7 @@ def test_generate_headers(self, http_client):
         headers = http_client._generate_headers()
         authorization_string = http_client._generate_bearer_header()
         user_agent_string = http_client._generate_user_agent()
-        
+
         # assert
         assert type(headers) == dict
         assert type(headers['Content-Type']) == str
@@ -91,7 +91,7 @@ def test_get_successful(self, http_client):
         response = http_client.get('/test')
 
         # assert
-        assert response.ok == True
+        assert response.ok is True
         assert response.status_code == 200
         assert response.text == '{}'
         assert response.headers['Content-Type'] == 'application/json'
@@ -111,7 +111,7 @@ def test_post_successful(self, http_client):
         response = http_client.post('/test', params={})
 
         # assert
-        assert response.ok == True
+        assert response.ok is True
         assert response.status_code == 200
         assert response.text == '{}'
         assert response.headers['Content-Type'] == 'application/json'
@@ -131,7 +131,7 @@ def test_delete_successful(self, http_client):
         response = http_client.delete('/test')
 
         # assert
-        assert response.ok == True
+        assert response.ok is True
         assert response.status_code == 200
         assert response.headers['Content-Type'] == 'application/json'
         assert responses.assert_call_count(http_client._base_url + '/test', 1) is True
@@ -141,10 +141,11 @@ def test_get_failed(self, http_client):
         responses.add(
             method=responses.GET,
             url=(http_client._base_url + '/test'),
-            status=401, 
+            status=401,
             json={'code': UNAUTHORIZED_REQUEST, 'message': UNAUTHORIZED_REQUEST_MESSAGE},
             content_type='application/json'
         )
+        error_str = f'error code: {UNAUTHORIZED_REQUEST}\nmessage: {UNAUTHORIZED_REQUEST_MESSAGE}'
 
         # act
         with pytest.raises(APIException) as excinfo:
@@ -153,13 +154,14 @@ def test_get_failed(self, http_client):
         # assert
         assert excinfo.value.code == UNAUTHORIZED_REQUEST
         assert excinfo.value.message == UNAUTHORIZED_REQUEST_MESSAGE
+        assert excinfo.value.__str__() == error_str
 
     def test_post_failed(self, http_client):
         # arrange - add response mock
         responses.add(
             method=responses.POST,
             url=(http_client._base_url + '/test'),
-            status=400, 
+            status=400,
             json={'code': INVALID_REQUEST, 'message': INVALID_REQUEST_MESSAGE},
             content_type='application/json'
         )
@@ -177,7 +179,7 @@ def test_delete_failed(self, http_client):
         responses.add(
             method=responses.DELETE,
             url=(http_client._base_url + '/test'),
-            status=400, 
+            status=400,
             json={'code': INVALID_REQUEST, 'message': INVALID_REQUEST_MESSAGE},
             content_type='application/json'
         )
@@ -188,4 +190,4 @@ def test_delete_failed(self, http_client):
 
         # assert
         assert excinfo.value.code == INVALID_REQUEST
-        assert excinfo.value.message == INVALID_REQUEST_MESSAGE
+        assert excinfo.value.message == INVALID_REQUEST_MESSAGE

tests/unit_tests/test_exceptions.py

@@ -0,0 +1,33 @@
+import pytest
+from datacrunch.exceptions import APIException
+
+ERROR_CODE = 'test_code'
+ERROR_MESSAGE = "test message"
+
+
+def test_api_exception_with_code():
+    # arrange
+    error_str = f'error code: {ERROR_CODE}\nmessage: {ERROR_MESSAGE}'
+
+    # act
+    with pytest.raises(APIException) as excinfo:
+        raise APIException(ERROR_CODE, ERROR_MESSAGE)
+
+    # assert
+        assert excinfo.value.code == ERROR_CODE
+        assert excinfo.value.message == ERROR_MESSAGE
+        assert excinfo.value.__str__() == error_str
+
+
+def test_api_exception_without_code():
+    # arrange
+    error_str = f'message: {ERROR_MESSAGE}'
+
+    # act
+    with pytest.raises(APIException) as excinfo:
+        raise APIException(None, ERROR_MESSAGE)
+
+    # assert
+        assert excinfo.value.code is None
+        assert excinfo.value.message == ERROR_MESSAGE
+        assert excinfo.value.__str__() == error_str