fixed bug and added test case

Author: tamirse

datacrunch/instances/instances.py

@@ -428,6 +428,6 @@ def is_available(self, instance_type: str, is_spot: bool = None) -> bool:
         :return: True if available to deploy, False otherwise
         :rtype: bool
         """
-        query_param = 'true' if is_spot else 'false'
-        url = f'/instance-availability/{instance_type}?isSpot={query_param}'
+        query_param = '?isSpot=true' if is_spot else ''
+        url = f'/instance-availability/{instance_type}{query_param}'
         return self._http_client.get(url).json()

tests/unit_tests/instances/test_instances.py

@@ -439,6 +439,23 @@ def test_is_available_successful(self, instances_service):
         assert is_available is True
         assert responses.assert_call_count(url, 1) is True
 
+    def test_is_spot_available_successful(self, instances_service):
+        # arrange - add response mock
+        url = instances_service._http_client._base_url + '/instance-availability/' + INSTANCE_TYPE + '?isSpot=true'
+        responses.add(
+            responses.GET,
+            url,
+            json=True,
+            status=200
+        )
+
+        # act
+        is_available = instances_service.is_available(INSTANCE_TYPE, is_spot=True)
+
+        # assert
+        assert is_available is True
+        assert responses.assert_call_count(url, 1) is True
+
     def test_is_available_failed(self, instances_service):
         # arrange - add response mock
         url = instances_service._http_client._base_url + '/instance-availability/x'