fix: resolve all golangci-lint issues and formatting

- goconst: extract "default" and "spot" to constants
- gocritic: paramTypeCombine, rangeValCopy, emptyStringTest, ifElseChain,
  dupBranchBody, hugeParam, appendCombine
- gocyclo: nolint for inherently complex interactive CLI functions
- misspell: organised→organized, Cancelled→Canceled
- nestif: nolint for interactive prompt flows
- nolintlint: remove unused gosec/nilerr directives
- perfsprint: errors.New for static strings, string concat
- prealloc: preallocate slices with correct capacity
- revive: add comment for blank import
- staticcheck: fmt.Fprintf instead of WriteString+Sprintf
- Remove modernize linter (unavailable in CI)
- Fix all goimports formatting

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: hi-lei

.gitignore

@@ -356,4 +356,4 @@ dist
 # temp dir
 tmp/
 temp/
-tmp-test-*/
+tmp-test-*/

.golangci.yaml

@@ -21,7 +21,6 @@ linters:
     - gosec
     - mirror
     - misspell
-    - modernize
     - nakedret
     - nestif
     - nilerr

internal/verda-cli/cmd/auth/auth_test.go

@@ -16,7 +16,7 @@ func TestWriteActiveProfile(t *testing.T) {
 		t.Fatalf("writeActiveProfile() returned error: %v", err)
 	}
 
-	data, err := os.ReadFile(path) //nolint:gosec // test file path
+	data, err := os.ReadFile(path)
 	if err != nil {
 		t.Fatalf("os.ReadFile() returned error: %v", err)
 	}

internal/verda-cli/cmd/auth/use.go

@@ -49,9 +49,9 @@ func NewCmdUse(_ cmdutil.Factory, ioStreams cmdutil.IOStreams) *cobra.Command {
 	return cmd
 }
 
-func writeActiveProfile(path string, profile string) error {
+func writeActiveProfile(path, profile string) error {
 	cfg := map[string]any{}
-	if data, err := os.ReadFile(path); err == nil { //nolint:gosec // path is from our own config
+	if data, err := os.ReadFile(path); err == nil {
 		if err := yaml.Unmarshal(data, &cfg); err != nil {
 			return err
 		}

internal/verda-cli/cmd/auth/wizard.go

@@ -1,13 +1,16 @@
 package auth
 
 import (
-	"fmt"
+	"errors"
 	"strings"
 
 	"github.com/verda-cloud/verdagostack/pkg/tui/wizard"
 )
 
-const defaultBaseURL = "https://api.verda.com/v1"
+const (
+	defaultBaseURL     = "https://api.verda.com/v1"
+	defaultProfileName = "default"
+)
 
 // buildLoginFlow builds the interactive wizard flow for auth login.
 //
@@ -34,16 +37,16 @@ func loginStepProfile(opts *loginOptions) wizard.Step {
 		Description: "Profile name",
 		Prompt:      wizard.TextInputPrompt,
 		Required:    true,
-		Default:     func(_ map[string]any) any { return "default" },
+		Default:     func(_ map[string]any) any { return defaultProfileName },
 		Validate: func(v any) error {
 			if strings.TrimSpace(v.(string)) == "" {
-				return fmt.Errorf("profile name cannot be empty")
+				return errors.New("profile name cannot be empty")
 			}
 			return nil
 		},
 		Setter:   func(v any) { opts.Profile = strings.TrimSpace(v.(string)) },
-		Resetter: func() { opts.Profile = "default" },
-		IsSet:    func() bool { return opts.Profile != "" && opts.Profile != "default" },
+		Resetter: func() { opts.Profile = defaultProfileName },
+		IsSet:    func() bool { return opts.Profile != "" && opts.Profile != defaultProfileName },
 		Value:    func() any { return opts.Profile },
 	}
 }
@@ -58,10 +61,10 @@ func loginStepBaseURL(opts *loginOptions) wizard.Step {
 		Validate: func(v any) error {
 			s := strings.TrimSpace(v.(string))
 			if s == "" {
-				return fmt.Errorf("base URL cannot be empty")
+				return errors.New("base URL cannot be empty")
 			}
 			if !strings.HasPrefix(s, "http://") && !strings.HasPrefix(s, "https://") {
-				return fmt.Errorf("base URL must start with http:// or https://")
+				return errors.New("base URL must start with http:// or https://")
 			}
 			return nil
 		},
@@ -80,7 +83,7 @@ func loginStepClientID(opts *loginOptions) wizard.Step {
 		Required:    true,
 		Validate: func(v any) error {
 			if strings.TrimSpace(v.(string)) == "" {
-				return fmt.Errorf("client ID cannot be empty")
+				return errors.New("client ID cannot be empty")
 			}
 			return nil
 		},

internal/verda-cli/cmd/auth/wizard_test.go

@@ -17,10 +17,10 @@ func TestBuildLoginFlowHappyPath(t *testing.T) {
 	}
 
 	mock := tuitest.New()
-	mock.AddTextInput("staging")                        // profile
-	mock.AddTextInput("https://staging-api.verda.com")  // base-url
-	mock.AddTextInput("my-id")                          // client-id
-	mock.AddPassword("my-secret")                       // client-secret
+	mock.AddTextInput("staging")                       // profile
+	mock.AddTextInput("https://staging-api.verda.com") // base-url
+	mock.AddTextInput("my-id")                         // client-id
+	mock.AddPassword("my-secret")                      // client-secret
 
 	flow := buildLoginFlow(opts)
 	engine := wizard.NewEngine(mock, nil)

internal/verda-cli/cmd/cmd.go

@@ -5,6 +5,7 @@ import (
 	"github.com/spf13/viper"
 	"github.com/verda-cloud/verdagostack/pkg/log"
 	"github.com/verda-cloud/verdagostack/pkg/tui/bubbletea"
+
 	"github/verda-cloud/verda-cli/internal/verda-cli/cmd/auth"
 	"github/verda-cloud/verda-cli/internal/verda-cli/cmd/settings"
 	"github/verda-cloud/verda-cli/internal/verda-cli/cmd/sshkey"
@@ -17,7 +18,7 @@ import (
 )
 
 // NewRootCommand creates the root `verda` cobra command with all subcommands
-// organised into logical groups.
+// organized into logical groups.
 func NewRootCommand(ioStreams cmdutil.IOStreams) *cobra.Command {
 	opts := clioptions.NewOptions()
 

internal/verda-cli/cmd/settings/theme.go

@@ -93,7 +93,7 @@ func selectTheme(cmd *cobra.Command, f cmdutil.Factory, ioStreams cmdutil.IOStre
 	prompter := f.Prompter()
 	idx, err := prompter.Select(cmd.Context(), "Select theme", labels)
 	if err != nil {
-		return nil //nolint:nilerr
+		return nil //nolint:nilerr // User pressed Esc/Ctrl+C during prompt.
 	}
 
 	return setTheme(f, ioStreams, names[idx])

internal/verda-cli/cmd/sshkey/add.go

@@ -2,6 +2,7 @@ package sshkey
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/spf13/cobra"
@@ -60,21 +61,21 @@ func runAdd(cmd *cobra.Command, f cmdutil.Factory, ioStreams cmdutil.IOStreams,
 	if name == "" {
 		name, err = prompter.TextInput(ctx, "SSH key name")
 		if err != nil {
-			return nil //nolint:nilerr
+			return nil
 		}
 		if name == "" {
-			return fmt.Errorf("name is required")
+			return errors.New("name is required")
 		}
 	}
 
 	publicKey := opts.PublicKey
 	if publicKey == "" {
 		publicKey, err = prompter.TextInput(ctx, "Public key (paste)")
 		if err != nil {
-			return nil //nolint:nilerr
+			return nil
 		}
 		if publicKey == "" {
-			return fmt.Errorf("public key is required")
+			return errors.New("public key is required")
 		}
 	}
 

internal/verda-cli/cmd/sshkey/delete.go

@@ -56,7 +56,7 @@ func runDelete(cmd *cobra.Command, f cmdutil.Factory, ioStreams cmdutil.IOStream
 	keyID := opts.ID
 	keyName := keyID
 
-	if keyID == "" {
+	if keyID == "" { //nolint:nestif // Interactive prompt flow requires nested conditionals.
 		// Interactive: list keys and let user select.
 		listCtx, cancel := context.WithTimeout(ctx, f.Options().Timeout)
 		defer cancel()
@@ -78,15 +78,15 @@ func runDelete(cmd *cobra.Command, f cmdutil.Factory, ioStreams cmdutil.IOStream
 			return nil
 		}
 
-		labels := make([]string, len(keys))
-		for i, k := range keys {
-			labels[i] = fmt.Sprintf("%s  %s  %s", k.Name, k.ID, k.Fingerprint)
+		labels := make([]string, 0, len(keys)+1)
+		for _, k := range keys {
+			labels = append(labels, fmt.Sprintf("%s  %s  %s", k.Name, k.ID, k.Fingerprint))
 		}
 		labels = append(labels, "Cancel")
 
 		idx, err := prompter.Select(ctx, "Select SSH key to delete", labels)
 		if err != nil {
-			return nil //nolint:nilerr
+			return nil
 		}
 		if idx == len(keys) {
 			return nil
@@ -99,7 +99,7 @@ func runDelete(cmd *cobra.Command, f cmdutil.Factory, ioStreams cmdutil.IOStream
 	// Confirm deletion.
 	confirmed, err := prompter.Confirm(ctx, fmt.Sprintf("Are you sure you want to delete SSH key %q?", keyName))
 	if err != nil || !confirmed {
-		_, _ = fmt.Fprintln(ioStreams.ErrOut, "Cancelled.")
+		_, _ = fmt.Fprintln(ioStreams.ErrOut, "Canceled.")
 		return nil
 	}