Skip to content

Allow 'delete' type in CBOR auxdata transformations and update validation functions#38

Merged
marcocastignoli merged 7 commits into
masterfrom
support-delete-type-auxdata-transformations
Feb 2, 2026
Merged

Allow 'delete' type in CBOR auxdata transformations and update validation functions#38
marcocastignoli merged 7 commits into
masterfrom
support-delete-type-auxdata-transformations

Conversation

@marcocastignoli
Copy link
Copy Markdown
Contributor

@marcocastignoli marcocastignoli commented Jan 26, 2026

Copy link
Copy Markdown
Member

@manuelwedler manuelwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update json-schemas/README.md, and add the length parameter and add an example for the delete type.

Comment thread migrations/20260126113330_allow_delete_cbor_auxdata_transformations.sql Outdated
Copy link
Copy Markdown
Member

@manuelwedler manuelwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments. I think it's important to define these things precisely, since this is for a shared database.

It would also be nice to add a python test for the adapted constraint.

Comment thread json-schemas/README.md Outdated
Comment thread migrations/20260126113330_allow_delete_cbor_auxdata_transformations.sql Outdated
Comment thread json-schemas/README.md Outdated
Comment thread json-schemas/README.md Outdated
Copy link
Copy Markdown
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to

  • Update the docs at https://verifieralliance.org/docs/transformations/
    • Should we maybe sync the docs with the README?
  • Notify other verifiers about the change
    • For letting them know I think it's still a bit difficult to grasp the problem so we should have a good summary

@marcocastignoli
Copy link
Copy Markdown
Contributor Author

@kuzdogan I opened a PR to sync the verifier alliance docs with the REAME.

@marcocastignoli
Copy link
Copy Markdown
Contributor Author

I also created this issue to be shared with the rest of the VerA implementers: #39

Copy link
Copy Markdown
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing and a wrong "minimum" value

Comment thread json-schemas/README.md
Comment thread json-schemas/verified_contracts-transformations.json Outdated
@marcocastignoli marcocastignoli merged commit 3b6a3c8 into master Feb 2, 2026
2 checks passed
@marcocastignoli marcocastignoli deleted the support-delete-type-auxdata-transformations branch February 2, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants