Reorder devcontainer failure handler to address race setting status (#384)

Author: pantherman594

startupscript/butane/devcontainer-failure-handler.sh

@@ -29,15 +29,16 @@ echo "failed: $(date)" >> "${RETRY_FILE}"
 # Check if number of retries have exceeded maximum
 num_retries="$(wc -l < "${RETRY_FILE}")"
 if [[ "${num_retries}" -ge "${RETRY_COUNT}" ]]; then
+        # Stop the service
+        systemctl stop devcontainer.service
+
         # Log failure
         source /home/core/metadata-utils.sh
         set_metadata "startup_script/status" "ERROR"
         error_message=$(get_guest_attribute "startup_script/message" "")
         if [[ -z "${error_message}" ]]; then
           set_metadata "startup_script/message" "There was an error launching your custom container on the VM. Please try recreating the VM."
         fi
-        # Stop the service
-        systemctl stop devcontainer.service
 
         if [[ "$SHUTDOWN_ON_FAILURE" == "true" ]]; then
             # Sleep for a bit in case logs need to be captured